-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mermaid-cli 8.11.4 #83338
mermaid-cli 8.11.4 #83338
Conversation
6b207a2
to
ee83843
Compare
on
failed to build on x86_64 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
I suspected we'd hit this problem with Apparently the reason Hypothetically that specific version of Chromium could be built from source, but I don't think we have any desire to do that. While we could make this macOS only and give it an audit exception for the universal binaries, I feel like that may just be a bandage and the reality is that a formula like this may not belong in |
I think copying a browser into your install is just taking it too far. I'd be in favor of disabling it. |
💯 On a more serious note the upstream repo does mention Homebrew as an install option, so if we decide to disable it maybe they should be notified? Fortunately I think macOS users would be fine installing it with In terms of popularity, it had 300 installs in the last 30 days. I'm not sure if that is considered "popular" on macOS, but those are numbers in case that helps with the decision. |
This actually doesn't install any universal binaries -- it installs x86_64-only binaries on ARM. The error text for universal binaries is |
I'd say that's pretty popular, but downloading a browser is a really bad packaging decision. So in my mind the problems outweigh the benefits (since a tap is easy to maintain). |
I agree that bundling a browser feels like a bit much. Sadly there isn't really a good substitute for Once upon a time there was a variant of headless variant of Chromium (not the same as running Chrome/Chromium with |
The packaging situation with
Thus far we've managed to hack around some of these issues by deleting upstream binaries, or figuring out how to build the binaries ourselves. But we have to draw the line somewhere, and this tool probably crosses it. I'm in favor of telling the upstream repo here to make a macOS-only tap, and just direct their Linux users to use Docker. Distributing a binary build of Chromium that would work on the range of Linux configurations we support is a fruitless exercise. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
Created with
brew bump-formula-pr
.