Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update brew formula to work with 9.0.3 #288

Closed
yogurtearl opened this issue Apr 26, 2022 · 6 comments
Closed

update brew formula to work with 9.0.3 #288

yogurtearl opened this issue Apr 26, 2022 · 6 comments
Labels
wontfix This will not be worked on

Comments

@yogurtearl
Copy link

yogurtearl commented Apr 26, 2022

Describe the bug

brew install mermaid-cli does not install the latest version.

See
Homebrew/homebrew-core#100192
and Homebrew/homebrew-core#83338

Need to update the formula to work with Apple silicon, and possibly make the formula mac-only (no linux support)

https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/mermaid-cli.rb#L6

@MindaugasLaganeckas
Copy link
Member

@yogurtearl you are welcome to create a PR. I will gladly review it 😄

@MindaugasLaganeckas
Copy link
Member

@yogurtearl I am not sure what exactly changes are needed to be applied to mermaid-cli project. One thing I can imagine could be to create a PR against the homebrew every time we make a CLI release, but that is a lot of work so help is needed. Regarding the other part of the comment and possibly make the formula mac-only (no linux support) - I have no idea what you mean.

@yogurtearl
Copy link
Author

One thing I can imagine could be to create a PR against the homebrew every time we make a CLI release, but that is a lot of work so help is needed.

could use brew bump-formula-pr from you GH action workflows on every release to automate the process.
https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request

and possibly make the formula mac-only (no linux support) - I have no idea what you mean.

been awhile since I wrote that and not sure what I meant either... 😅

@MindaugasLaganeckas
Copy link
Member

Unfortunately, I do not have mac, where I could experiment and implement the solution. If you create a PR for it, I will gladly accept it 😄

@mrcnski
Copy link

mrcnski commented Oct 6, 2022

Bump. 🙂

Right now brew install mermaid-cli gives me this warning:

Warning: mermaid-cli has been deprecated because it installs a pre-built copy of Chromium!

@aloisklink
Copy link
Member

Warning: mermaid-cli has been deprecated because it installs a pre-built copy of Chromium!

Unfortunately, mermaid-cli requires puppeteer, which requires either Chromium or Firefox. And since both Chromium and Firefox are not yet available as Homebrew Formulae (they're just Casks), the Homebrew team has decided to deprecate meramid-cli, see Homebrew/homebrew-core#100192 (comment):

Closing based on decision from Homebrew side.

The way forward for mermaid-cli formula would be an external Tap, perhaps maintained by upstream or someone else. If one is created, it can be considered for documentation at https://docs.brew.sh/Interesting-Taps-and-Forks

I'm going to close this as won't fix, since the Homebrew team has said they won't be accepting updates to the mermaid-cli formula.

The homebrew team thinks mermaid-cli could be turned into a Tap. https://docs.brew.sh/Acceptable-Casks#rejected-casks also says that it might be accepted as a Cask, despite being a CLI software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants