Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula for mermaid-cli is not pointing to latest stable. #100192

Closed
2 tasks done
yogurtearl opened this issue Apr 26, 2022 · 7 comments
Closed
2 tasks done

formula for mermaid-cli is not pointing to latest stable. #100192

yogurtearl opened this issue Apr 26, 2022 · 7 comments
Labels
outdated PR was locked due to age wontfix Will not fix this issue

Comments

@yogurtearl
Copy link

yogurtearl commented Apr 26, 2022

brew gist-logs <formula> link OR brew config AND brew doctor output

HOMEBREW_VERSION: 3.4.8
ORIGIN: https://github.com/Homebrew/brew
HEAD: c2eaeed0b5978ef3e455cc29dda7e9e0b7a0670f
Last commit: 4 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 23a754deb53e4df9b02b581c0075227a34764de6
Core tap last commit: 53 minutes ago
Core tap branch: master

Verification

  • I ran brew update and am still able to reproduce my issue.
  • I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?

install latest version of mermaid-cli (9.0.3)

Tagged here:
https://github.com/mermaid-js/mermaid-cli/releases/tag/9.0.3

What happened (include all command output)?

Formula points to 8.11.0 instead of 9.0.3 (or newer)

https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/mermaid-cli.rb#L6

What did you expect to happen?

Use latest stable version.

Step-by-step reproduction instructions (by running brew commands)

`brew install mermaid-cli`
@yogurtearl yogurtearl added the bug Reproducible Homebrew/homebrew-core bug label Apr 26, 2022
@nandahkrishna
Copy link
Member

Multiple previous attempts to bump this formula have failed. See discussion in #93625 and #83338.

@Bo98
Copy link
Member

Bo98 commented Apr 27, 2022

As it stands mermaid-cli violates our build-from-source policy.

I think the way forward (unless there's a way to make it fit into Homebrew/core's policies) is to deprecate this and allow a third-party tap with less ties to open source to deal with it going forward.

@cho-m
Copy link
Member

cho-m commented Apr 27, 2022

Another puppeteer-based formula currently under review is #98549 which is trying to defer browser installation to user (Firefox in their case).

The tedious way that AUR supports is building chromium from source (https://repology.org/project/chromium/versions).

@carlocab
Copy link
Member

Building chromium from source would be a huge pain. Not to mention that they tag new builds as often as multiple times a day.

@MikeMcQuaid
Copy link
Member

As it stands mermaid-cli violates our build-from-source policy.

I think the way forward (unless there's a way to make it fit into Homebrew/core's policies) is to deprecate this and allow a third-party tap with less ties to open source to deal with it going forward.

👍🏻

@cho-m cho-m mentioned this issue Apr 30, 2022
6 tasks
@cho-m cho-m added wontfix Will not fix this issue and removed bug Reproducible Homebrew/homebrew-core bug labels Apr 30, 2022
@cho-m
Copy link
Member

cho-m commented Apr 30, 2022

Will proceed with deprecation in #100478.

Since original question was on updating to latest version, also labelled as wontfix.

@cho-m
Copy link
Member

cho-m commented May 1, 2022

Closing based on decision from Homebrew side.

The way forward for mermaid-cli formula would be an external Tap, perhaps maintained by upstream or someone else. If one is created, it can be considered for documentation at https://docs.brew.sh/Interesting-Taps-and-Forks

@cho-m cho-m closed this as completed May 1, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age wontfix Will not fix this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants