Conversation
| patch do | ||
| url "https://github.com/fxcoudert/cpython/commit/cd26ccbb.patch?full_index=1" | ||
| sha256 "59c98f991f839d610d53ca5c4af1464a99adf6c85e807f8a676b3e41c5dbe0a2" | ||
| end |
There was a problem hiding this comment.
Can we move this to formula-patches.
There was a problem hiding this comment.
It's the commit from the upstream pull request (which I opened myself). I tried to use the PR URL, but then it complains.
There was a problem hiding this comment.
You can use the commit hash in the PR vs from your branch: https://github.com/python/cpython/commit/cd26ccbbf97be0d729196df3ec2a25ef4f0c57f8.patch?full_index=1 .
Disallowing the PR URL itself was removed because the contents of the PR can change. If there are multiple commits, then using formula-patches can make more sense.
| @@ -4,7 +4,7 @@ class PythonAT39 < Formula | |||
| url "https://www.python.org/ftp/python/3.9.0/Python-3.9.0.tar.xz" | |||
There was a problem hiding this comment.
I think 3.9.1 is out already, would you care to try it?
There was a problem hiding this comment.
It's still a release candidate https://www.python.org/ftp/python/3.9.1/ with it scheduled to be released on December 11 https://www.python.org/dev/peps/pep-0596/
There was a problem hiding this comment.
Ah okay, we should fix the livecheck then
There was a problem hiding this comment.
Not sure how we usually handle these livecheck issues. At first glance, maybe we can use https://www.python.org/downloads/source/ with a regex that matches Latest Python 3 Release - Python 3.9.\d+
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@robandres All Homebrew maintainers are volunteers working on this on their free time. “Please do this” does not help at all, especially when there is a clear reason we can't immediately “do this”. In the present case, the update is undergoing testing before we can merge it: because there are a lot of Python formulas, this takes time. I started this testing yesterday before going to bed, and am checking on it this morning as I wake up; seeing your comment “merge this” is actually quite annoying to me. There are many ways to actually support Homebrew, through proposing pull requests, opening carefully described issues when you have a reproducible problem, supporting others and new users in the discussions, or sponsorship (that helps pay for hardware for testing). |
|
I will also mention that python37 and 38 have the same issues. Does it make sense to take a similar approach to 37 and 38? |
|
A patch for older pythons would be welcome |
|
@fxcoudert, appreciate your efforts on the previous patch. for example, brew install python@3.9
pip3 install markupsafereturns I suspect the underlying Apple common python uses to get in MacOS High Sierra>>> import sysconfig
>>> sysconfig.get_config_var('MACOSX_DEPLOYMENT_TARGET')
'10.14.6'in BigSur>>> import sysconfig
>>> sysconfig.get_config_var('MACOSX_DEPLOYMENT_TARGET')
'11'I'm currently looking for a tidy way to address this. I imagine this |
|
@BracketMaster thanks! I think a fix is already in the works over in #66063 (correct me if I'm wrong and that's not a fix for this issue) |
|
@Rylan12 , those patches don't hit all the problems. I can open a pull request for that. This should also fix the build issues for python37 and 38 I know that I inserted |
New pip release, including important Big Sur fixes