Skip to content

molecule: update resource block instructions#66018

Closed
Rylan12 wants to merge 1 commit intoHomebrew:masterfrom
Rylan12:molecule-resource-instructions
Closed

molecule: update resource block instructions#66018
Rylan12 wants to merge 1 commit intoHomebrew:masterfrom
Rylan12:molecule-resource-instructions

Conversation

@Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Dec 1, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Now that we have some more advanced functionality in update-python-resources, I've added some instructions for updating molecule's resources using the new options.

Also bumped some resources (using the method described in the instructions!).

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Dec 1, 2020
@Rylan12
Copy link
Member Author

Rylan12 commented Dec 1, 2020

ERROR: Command errored out with exit status 1: /usr/local/Cellar/molecule/3.2.0/libexec/bin/python /usr/local/Cellar/molecule/3.2.0/libexec/lib/python3.9/site-packages/pip install --ignore-installed --no-user --prefix /private/tmp/pip-build-env-iz_bewic/overlay --no-warn-script-location -v --no-binary :all: --only-binary :none: -i https://pypi.org/simple -- 'setuptools>=40.8.0' wheel 'cffi>=1.1; python_implementation != '"'"'PyPy'"'"'' Check the logs for full command output.

Not sure what to make of this. I thought this was fixed in #65953. Also why only for 11.0? I'll continue to investigate.

Edit: I didn't really paste enough of the error message to give anything helpful, I think 😅

@chenrui333 chenrui333 added 11 Big Sur is specifically affected build failure CI fails while building the software labels Dec 2, 2020
@chenrui333
Copy link
Member

having the same issue in certbot pr, #66055

@Rylan12
Copy link
Member Author

Rylan12 commented Dec 2, 2020

Good to know, thanks. I haven't looked into this at all, yet (aside from verifying that it also fails for me locally). I've got a busier day tomorrow so may not be able to look into it until later. Let me know if you find anything.


Just a note: molecule built without any issues 3 days ago in #65846 so something must have changed since then. I haven't updated the molecule formula, so I think it's either an issue with the changing resources, a change in something else in homebrew/core (possibly python@3.9), a change in the brew code. I'm leaning toward "a change in something else in homebrew/core (possibly python@3.9)".

@dtrodrigues
Copy link
Member

dtrodrigues commented Dec 2, 2020

The PR pulled in by #65953 has been updated to address the couple other places the issue is manifesting: python/cpython#23556 . We'll probably need to do another Python revision bump once the upstream PR is finalized.

        File "/usr/local/Cellar/python@3.9/3.9.0_3/Frameworks/Python.framework/Versions/3.9/lib/python3.9/distutils/spawn.py", line 66, in spawn
          if _cfg_target_split > [int(x) for x in cur_target.split('.')]:
      AttributeError: 'int' object has no attribute 'split'

is fixed based on python/cpython#23556 (comment)

@fxcoudert

@Rylan12
Copy link
Member Author

Rylan12 commented Dec 3, 2020

@fxcoudert FYI this is still failing albeit with a slightly different error message:

    File "/private/tmp/pip-build-env-4hijcw35/overlay/lib/python3.9/site-packages/wheel/macosx_libfile.py", line 356, in calculate_macosx_platform_tag
      assert len(base_version) == 2

It looks (without investigating at all) to be related to another issue with the new macOS version scheme. Will try to investigate more later but I'm not familiar with the code here at all, so figured you may have an idea.

Edit: ah, now I see that this is the issue reported in pypa/wheel#385. It sounds like a fix will be needed upstream, so nothing to be done here yet.

And update some resources while we're at it
@Rylan12
Copy link
Member Author

Rylan12 commented Dec 8, 2020

Okay, now that the python@3.9 issue is resolved this should be good to go

@Rylan12 Rylan12 removed 11 Big Sur is specifically affected build failure CI fails while building the software labels Dec 8, 2020
@BrewTestBot
Copy link
Contributor

🤖 A scheduled task has triggered a merge.

@Rylan12 Rylan12 deleted the molecule-resource-instructions branch December 8, 2020 18:52
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 8, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age python Python use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants