Skip to content

python@3.9: update pip #65953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fxcoudert wants to merge 1 commit into from
Closed

python@3.9: update pip #65953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions Formula/python@3.9.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class PythonAT39 < Formula
url "https://www.python.org/ftp/python/3.9.0/Python-3.9.0.tar.xz"
Copy link
Member

@SMillerDev SMillerDev Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 3.9.1 is out already, would you care to try it?

Copy link
Member

@dtrodrigues dtrodrigues Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still a release candidate https://www.python.org/ftp/python/3.9.1/ with it scheduled to be released on December 11 https://www.python.org/dev/peps/pep-0596/

Copy link
Member

@SMillerDev SMillerDev Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, we should fix the livecheck then

Copy link
Member

@Rylan12 Rylan12 Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how we usually handle these livecheck issues. At first glance, maybe we can use https://www.python.org/downloads/source/ with a regex that matches Latest Python 3 Release - Python 3.9.\d+

sha256 "9c73e63c99855709b9be0b3cc9e5b072cb60f37311e8c4e50f15576a0bf82854"
license "Python-2.0"
revision 2
revision 3

livecheck do
url "https://www.python.org/ftp/python/"
Expand Down Expand Up @@ -66,8 +66,8 @@ class PythonAT39 < Formula
end

resource "pip" do
url "https://files.pythonhosted.org/packages/0b/f5/be8e741434a4bf4ce5dbc235aa28ed0666178ea8986ddc10d035023744e6/pip-20.2.4.tar.gz"
sha256 "85c99a857ea0fb0aedf23833d9be5c40cf253fe24443f0829c7b472e23c364a1"
url "https://files.pythonhosted.org/packages/03/41/6da553f689d530bc2c337d2c496a40dc9c0fdc6481e5df1f3ee3b8574479/pip-20.3.tar.gz"
sha256 "9ae7ca6656eac22d2a9b49d024fc24e00f68f4c4d4db673d2d9b525c3dea6e0e"
end

resource "wheel" do
Expand All @@ -83,6 +83,13 @@ class PythonAT39 < Formula
url "https://raw.githubusercontent.com/Homebrew/formula-patches/33a9d63f/python/arm64-3.9.patch"
sha256 "167e328cf68e9ec142f483fda9fafbb903be9a47dee2826614fdc24b2fbe6e06"
end

# Further patch for Big Sur, remove in 3.9.2
# https://github.com/python/cpython/pull/23556
patch do
url "https://github.com/fxcoudert/cpython/commit/cd26ccbb.patch?full_index=1"
sha256 "59c98f991f839d610d53ca5c4af1464a99adf6c85e807f8a676b3e41c5dbe0a2"
end
Comment on lines +89 to +92
Copy link
Member

@SMillerDev SMillerDev Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to formula-patches.

Copy link
Member Author

@fxcoudert fxcoudert Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the commit from the upstream pull request (which I opened myself). I tried to use the PR URL, but then it complains.

Copy link
Member

@dtrodrigues dtrodrigues Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the commit hash in the PR vs from your branch: https://github.com/python/cpython/commit/cd26ccbbf97be0d729196df3ec2a25ef4f0c57f8.patch?full_index=1 .

Disallowing the PR URL itself was removed because the contents of the PR can change. If there are multiple commits, then using formula-patches can make more sense.

end

def install
Expand Down