expert_nodes.hpp: include boost noncopyable.hpp#241
Closed
scpeters wants to merge 1 commit intoEttusResearch:masterfrom
Closed
expert_nodes.hpp: include boost noncopyable.hpp#241scpeters wants to merge 1 commit intoEttusResearch:masterfrom
scpeters wants to merge 1 commit intoEttusResearch:masterfrom
Conversation
Fixes a build failure with boost 1.69 reported in EttusResearch#240.
scpeters
commented
Jan 10, 2019
| #include <uhd/exception.hpp> | ||
| #include <uhd/utils/dirty_tracked.hpp> | ||
| #include <uhd/types/time_spec.hpp> | ||
| #include <boost/core/noncopyable.hpp> |
Author
There was a problem hiding this comment.
Note that boost/core/noncopyable.hpp is not present in boost 1.55 and earlier. Other files in this repo include boost/noncopyable.hpp, which is also present in boost 1.69, though it was deprecated in boost 1.56. If old boost versions must be supported, this could be changed to use the deprecated header file location.
Contributor
|
Thanks very much! We already have a fix for this in our internal CI pipeline, it was a bit more involved than your change since we need to check the Boost version like you stated. Keep your eyes open for the fix, it's coming soon! |
Author
|
thanks! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a build failure with boost 1.69 reported in #240.
Pull Request Details
Description
Add a missing header file to fix a build failure with boost 1.69.
Related Issue
This issue was reported in #240, and this pull request is an adaptation of a patch posted to that issue.
Which devices/areas does this affect?
N/A.
Testing Done
Tested on macOS mojave with homebrew Homebrew/homebrew-core#35030.
Checklist