Merged
Conversation
botantony
approved these changes
Jan 10, 2026
Contributor
|
🤖 An automated task has requested bottles to be published to this PR. Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.Details
release notes
Fixes Please complete the implementation for dropping a schema in Doltgres dolthub/doltgresql#2159
Fixes bit type is not supported dolthub/doltgresql#2149
bpchar(N)castingFixes: PostgreSQL compat: select '1'::bpchar(1) fails dolthub/doltgresql#2145
Fixes #2147
Summary
Adds aValidateCreateSchemaanalyzer rule to ensureCREATE SCHEMAfails that appropriately when executed against a non-existent or invalid database context.CREATE SCHEMAto proceedNote
I wasn't 100% sure if adding an analyzer rule was the right approach here, but it seemed like the cleanest way to validate database context before schema creation. The rule follows the same pattern as existing validation rules likeValidateCreateTable.The connection-level validation (rejecting connections to non-existent databases) already handles most cases, but this analyzer rule acts as an additional safety net for edge cases where a query might run with an invalid database context (also not sure how realistic this is 😕 ).
Open to feedback on whether there's a better approach!
Testing
bats --filter "non-existent database|CREATE SCHEMA works" testing/bats/doltgres.batsgo test ./testing/go/... -run TestSchemas -vCloses: #1863
Summary
SELECT DOLT_CLEAN()zero-argument smoke tests that were added in #1373Function0registration for all Dolt proceduresDOLT_CLEAN('t1')runs beforeDOLT_CLEAN()to properly test bothNote: #1373 also added skipped tests in
prepared_statement_test.go, but those were already unskipped in commit 62569c79.Tests to verify
go test ./testing/go/... -run "TestDoltClean"to verify existing dolt_clean tests passgo test ./testing/go/... -run "TestDoltFunctionSmokeTests/smoke_test_select_dolt_clean"to verify unskipped smoke tests passFixes #1361
Summary
Remove outdated skip list entries for tests that were previously panicking due to an OR condition index lookup bug. The underlying issue was fixed in PR #2123.What was the problem?
Issue #1868 reported a panic when executing queries like:What fixed it?
I believe PR #2123 fixed this issue. In the PR it implemented aLogicTreeWalkerfor DoltgreSQL that properly handles doltgres-specific expression nodes when analyzing filters. This allows the query optimizer to correctly handle OR expressions with mixed indexed/non-indexed columns.Changes in this PR
Removed 3 entries from the engine test skip list:Complex Filter Index Scan #2Complex Filter Index Scan #3complicated range treeAll three tests now pass.
Testing
Fixes #1868
IMPORTANT
Below is the summary of the cause of the bug in #1057 and the simple fix, but I want to clarify this is the desired fix.Summary
DESCRIBE dolt.statusfailing with "at or near 'status': syntax error"STATUSto thesimple_identgrammar rule insql.y, following the pattern established forPUBLICin PR #828Background
Thesimple_identrule is used for parsing table name components in DESCRIBE statements. It only allowedIDENTtokens and the explicitly addedPUBLICkeyword. SinceSTATUSis an unreserved keyword (not a regular identifier), the parser rejected it unless quoted.Before:
DESCRIBE dolt.statusfails,DESCRIBE dolt."status"worksAfter: Both work
Test Plan
DESCRIBE dolt.statustest now passes (TestUserSpaceDoltTables/dolt_status)Fixes #1057
SHOW TABLESbugAdds a test for a bug in
SHOW TABLESbehavior that caused sequences to be included in returned results.Depends on: bug fix: stop including all root objects when getting tables on the search path dolthub/dolt#10220
Fixes: SHOW TABLES should not show sequences dolthub/doltgresql#1743
Closed Issues
dolt_cleanprocedure does not work if no arguments provideddescribe dolt.statusdoesn't workView the full release notes at https://github.com/dolthub/doltgresql/releases/tag/v0.54.8.