Skip to content

drop schema support#2172

Merged
zachmu merged 16 commits intomainfrom
zachmu/drop-schema
Jan 9, 2026
Merged

drop schema support#2172
zachmu merged 16 commits intomainfrom
zachmu/drop-schema

Conversation

@zachmu
Copy link
Copy Markdown
Member

@zachmu zachmu commented Jan 7, 2026

Fixes #2159

@zachmu zachmu requested a review from Hydrocharged January 7, 2026 00:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 7, 2026

Main PR
covering_index_scan_postgres 561.16/s 570.77/s +1.7%
index_join_postgres 118.45/s 120.31/s +1.5%
index_join_scan_postgres 179.62/s 179.67/s 0.0%
index_scan_postgres 11.27/s 11.35/s +0.7%
oltp_point_select 2331.31/s 2343.97/s +0.5%
oltp_read_only 1691.00/s 1714.46/s +1.3%
select_random_points 106.91/s 107.77/s +0.8%
select_random_ranges 429.42/s 433.56/s +0.9%
table_scan_postgres 10.87/s 11.09/s +2.0%
types_table_scan_postgres 5.11/s 5.12/s +0.1%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 7, 2026

Main PR
Total 42090 42090
Successful 17505 17514
Failures 24585 24576
Partial Successes1 5587 5587
Main PR
Successful 41.5895% 41.6108%
Failures 58.4105% 58.3892%

${\color{lightgreen}Progressions (8)}$

alter_table

QUERY: DROP SCHEMA alter2;

collate.icu.utf8

QUERY: DROP SCHEMA test_schema;

drop_if_exists

QUERY: DROP SCHEMA IF EXISTS test_schema_exists;
QUERY: DROP SCHEMA IF EXISTS test_schema_exists;

fast_default

QUERY: DROP SCHEMA fast_default;

guc

QUERY: drop schema not_there_initially;

publication

QUERY: DROP SCHEMA testpub_rf_schema1;
QUERY: DROP SCHEMA testpub_rf_schema2;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmu zachmu merged commit b55bd4e into main Jan 9, 2026
17 checks passed
@zachmu zachmu deleted the zachmu/drop-schema branch January 9, 2026 20:30
@chrisfw
Copy link
Copy Markdown

chrisfw commented Jan 9, 2026

Thank you @zachmu and @Hydrocharged !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please complete the implementation for dropping a schema in Doltgres

3 participants