You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩
The reason will be displayed to describe this comment to others. Learn more.
Type implementations require a bit more diligence with checking Postgres documentation and behavior compared to other feature inclusions. There are a lot of delicate rules that we need to follow that can cause hard-to-debug bugs if we're incorrect in a seemingly unrelated way (such as function overload selection). I'll approve assuming this'll all get updated correctly.
The reason will be displayed to describe this comment to others. Learn more.
We can verify if it's correct by connecting it to your local Postgres database and inserting the same query, which we should technically be doing for all of these kinds of queries if we're ever unsure. This should be tested before merging in case it's broken for this case, as bad data is harder to fix once it's in the wild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2149