Closed
Conversation
scpeters
reviewed
Mar 14, 2025
c23fa1c to
bcb61a0
Compare
bcb61a0 to
f5611b8
Compare
Member
|
Linux is going to be the blocker as we've been hitting some error for a while now (e.g. OpenCV PRs like #208693) which is showing up here: |
This was referenced Mar 14, 2025
f5611b8 to
41940fa
Compare
12 tasks
Member
|
Protobuf 30.2 is available |
41940fa to
cb8bbce
Compare
cb8bbce to
b7a92e3
Compare
b7a92e3 to
1e13cec
Compare
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
1e13cec to
7acdf47
Compare
|
I believe the PR #227847 is unnecessary -- I tried to run the failing test against protobuf 30.1 and it passes. Looking at the test, it does something silly: it looks if runtime was more than 1 wallclock second, and if so, fails. I think the runner was just busy. I'll make a note to fix this test, but in the meantime, please retry with protobuf 30.1 for mosh. |
Member
|
Closing this in favour of #228410 |
carlocab
added a commit
to Homebrew/brew
that referenced
this pull request
Aug 10, 2025
We have multiple formulae (e.g. `ola`, `openvino`, `opencv`, `or-tools`, `pytorch`) that seem to be broken by `patchelf.rb` on x86_64 Linux.[^1] The common thread seems to be the presence of a `protodesc_cold` section in the ELF header. Let's avoid breaking these bottles by skipping relocation when a binary file has a `protodesc_cold` section. It will probably hurt relocatability of these bottles, but that's better shipping broken binaries. [^1]: Homebrew/homebrew-core#210860 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.TODO, split out Protobuf 29 downgrades
mysql/percona-server- percona-server: useprotobuf@29#211057olaor-toolsBlocked by Linux formulae that fail with
Check failed: GeneratedDatabase()->Add(encoded_file_descriptor, size)ola(only has direct dependency onprotobuf@29)openvino(has multiple dependencies onprotobuffrom direct andonnx)opencv(has multiple dependencies onprotobuffrom direct,openvinoandonnx)or-tools(only has direct dependency onprotobuf)pytorchBackports:
netdata- netdata/netdata@a6cc221protobuf-c- protobuf-c/protobuf-c@2517481Workarounds:
openvino- add workaround to allow newer Protobuf. Need to report upstreamFollow ups to report upstream:
brpclibpulsar- [Bug] Build fails with Protobuf 30 from type changes apache/pulsar-client-cpp#478openvinoprotoc-gen-grpc-webprotoc-gen-jsmysql/percona-server