Conversation
cba4052 to
656071d
Compare
protobuf: remove build patch Signed-off-by: Rui Chen <rui@chenrui.dev>
656071d to
5a9fba3
Compare
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
looking at the it seems related to protocolbuffers/protobuf#21755 |
|
That's a bit of a rabithole. @scpeters am I correct in thinking there is no usable patch there for us and we might have to wait until 32 (potentially this month). |
it is indeed a rabbithole. It sounds like there might not be a fix in 32, and I commented in protocolbuffers/protobuf#21755 (comment) to clarify |
|
Is there an easy way to reproduce the error? If so then I could take a look. I kind of suspect it is not related to protocolbuffers/protobuf#21755 despite the similar error message, because we have been using linker arrays on Linux for a while with no issues. I would guess that something else is going wrong with the way the linker command is set up, like perhaps an ODR violation. |
I think this should get you started building this PR, if you don't have Homebrew installed on linux you can also use our docker container: brew update
cd $(brew --repo homebrew/core)
git checkout bump-protobuf-31.1
export HOMEBREW_NO_INSTALL_FROM_API=1
brew install --build-from-source grpc |
|
Rolling this into #227169. |
|
Other PR merged |
Created by
brew bumpCreated with
brew bump-formula-pr.