Skip to content

Comments

protobuf 31.1#228410

Closed
bevanjkay wants to merge 28 commits intomainfrom
bump-protobuf-31.1
Closed

protobuf 31.1#228410
bevanjkay wants to merge 28 commits intomainfrom
bump-protobuf-31.1

Conversation

@bevanjkay
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jun 28, 2025
@bevanjkay bevanjkay force-pushed the bump-protobuf-31.1 branch from cba4052 to 656071d Compare June 28, 2025 03:06
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request alias labels Jun 28, 2025
protobuf: remove build patch

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 force-pushed the bump-protobuf-31.1 branch from 656071d to 5a9fba3 Compare June 28, 2025 15:19
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions bot added the long build Set a long timeout for formula testing label Jun 28, 2025
@chenrui333 chenrui333 added CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels Jun 28, 2025
chenrui333 and others added 2 commits June 28, 2025 13:46
@chenrui333 chenrui333 added the in progress Stale bot should stay away label Jun 29, 2025
@artanokhov artanokhov mentioned this pull request Jul 2, 2025
6 tasks
@scpeters
Copy link
Contributor

scpeters commented Jul 7, 2025

looking at the grpc_cli linking error on Linux x86_64 (log):

/home/linuxbrew/.linuxbrew/lib/libupb.a(extension_registry.c.o): undefined reference to symbol '__stop_linkarr_upb_AllExts'
  /usr/bin/ld: libupb_mini_table_lib.so.48.0.0: error adding symbols: DSO missing from command line

it seems related to protocolbuffers/protobuf#21755

@SMillerDev
Copy link
Member

That's a bit of a rabithole. @scpeters am I correct in thinking there is no usable patch there for us and we might have to wait until 32 (potentially this month).

@scpeters
Copy link
Contributor

scpeters commented Jul 7, 2025

That's a bit of a rabithole. @scpeters am I correct in thinking there is no usable patch there for us and we might have to wait until 32 (potentially this month).

it is indeed a rabbithole. It sounds like there might not be a fix in 32, and I commented in protocolbuffers/protobuf#21755 (comment) to clarify

@Moisan Moisan mentioned this pull request Jul 7, 2025
6 tasks
@acozzette
Copy link

Is there an easy way to reproduce the error? If so then I could take a look. I kind of suspect it is not related to protocolbuffers/protobuf#21755 despite the similar error message, because we have been using linker arrays on Linux for a while with no issues. I would guess that something else is going wrong with the way the linker command is set up, like perhaps an ODR violation.

@SMillerDev
Copy link
Member

Is there an easy way to reproduce the error?

I think this should get you started building this PR, if you don't have Homebrew installed on linux you can also use our docker container:

brew update
cd $(brew --repo homebrew/core)
git checkout bump-protobuf-31.1
export HOMEBREW_NO_INSTALL_FROM_API=1
brew install --build-from-source grpc

@SMillerDev SMillerDev mentioned this pull request Jul 22, 2025
14 tasks
@carlocab
Copy link
Member

carlocab commented Aug 8, 2025

Rolling this into #227169.

@carlocab carlocab marked this pull request as draft August 8, 2025 08:51
@carlocab carlocab added the rollup proposed It has been proposed that this PR's commits are cherry-picked and merged as a part of another PR label Aug 8, 2025
@cho-m
Copy link
Member

cho-m commented Aug 14, 2025

@cho-m cho-m closed this Aug 14, 2025
@github-actions github-actions bot deleted the bump-protobuf-31.1 branch August 14, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alias automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. in progress Stale bot should stay away long build Set a long timeout for formula testing rollup proposed It has been proposed that this PR's commits are cherry-picked and merged as a part of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants