Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
🤖 An automated task has requested bottles to be published to this PR. Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
mosh crashes with a segfault after this change on Arm macOS See also: mobile-shell/mosh#1343 |
|
Hi, mosh maintainer here. It would be good to know what 806a5df was trying to accomplish. I don't understand why mosh is being pinned to older protobuf, and in fact that's older than the version of protobuf we build with generally. |
| # Mosh provides remote shell access, so let's run the tests to avoid shipping an insecure build. | ||
| system "make", "check" if OS.mac? # Fails on Linux. |
There was a problem hiding this comment.
since the test passed for this PR, can you propose a better test to catch the bug?
There was a problem hiding this comment.
see the check log failures in https://github.com/Homebrew/homebrew-core/actions/runs/15837271549/job/44643440144?pr=227933
There was a problem hiding this comment.
The test failure was best I can tell a flake. I will have to address this upstream, but I don't have an ETA right now. Disabling the rest is acceptable
5 participants
mosh: use
protobuf@29split from #210860