Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartsim 6.14.1 #175563

Merged
merged 2 commits into from
Jun 28, 2024
Merged

dartsim 6.14.1 #175563

merged 2 commits into from
Jun 28, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
### [DART 6.14.0 (2024-06-24)](https://github.com/dartsim/dart/milestone/73?closed=1)

This release is mostly a maintenance update, including various CI updates and build fixes for recent development environment toolsets and dependencies.

  • Tested Platforms

    • Linux
      • Ubuntu 22.04 LTS / GCC 11.4 / x86_64
      • Ubuntu 24.04 LTS / GCC 13.2 / x86_64
    • macOS 14 / Clang 15 / arm64
    • Windows / MSVC 19.40 / x86_64
  • Breaking Changes

    • Removed planning component
  • Build

    • Added Pixi support
  • General

    • Added profile interface with Tracy backend support
    • Added benchmark setup, including boxes and kinematics benchmarks
  • Dynamics

Full Changelog: dartsim/dart@v6.13.2...v6.14.0

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` autosquash Automatically squash pull request commits according to Homebrew style. labels Jun 25, 2024
@scpeters
Copy link
Member

build failure looks related to FetchContent for googletest:

 CMake Error at /opt/homebrew/Library/Homebrew/cmake/trap_fetchcontent_provider.cmake:12 (message):
    Refusing to populate dependency 'googletest' with FetchContent while
    building in Homebrew, please use a formula dependency or add a resource to
    the formula.
  Call Stack (most recent call first):
    /opt/homebrew/Cellar/cmake/3.29.6/share/cmake/Modules/FetchContent.cmake:2017:EVAL:1 (trap_fetchcontent_provider)
    /opt/homebrew/Cellar/cmake/3.29.6/share/cmake/Modules/FetchContent.cmake:2017 (cmake_language)
    tests/CMakeLists.txt:44 (FetchContent_MakeAvailable)

This is new since Homebrew/brew#17310.

I would suggest adding -DBUILD_TESTING=OFF to just skip testing, but I don't think upstream supports that. I'll try submitting a patch to enable BUILD_TESTING

@chenrui333
Copy link
Member

I would suggest adding -DBUILD_TESTING=OFF to just skip testing, but I don't think upstream supports that. I'll try submitting a patch to enable BUILD_TESTING

make sense to me.

@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 25, 2024
@chenrui333
Copy link
Member

  CMake Warning at cmake/DARTMacros.cmake:145 (message):
    Looking for doxygen - NOT found, to use generating API documentation,
    please install doxygen
  Call Stack (most recent call first):
    cmake/DARTFindDependencies.cmake:141 (dart_check_optional_package)
    CMakeLists.txt:212 (include)
  
  
  CMake Warning at cmake/DARTMacros.cmake:145 (message):
    Looking for pagmo - NOT found, to use dart-optimizer-pagmo, please install
    pagmo
  Call Stack (most recent call first):
    dart/optimizer/pagmo/CMakeLists.txt:3 (dart_check_optional_package)

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jun 25, 2024
@scpeters
Copy link
Member

I would suggest adding -DBUILD_TESTING=OFF to just skip testing, but I don't think upstream supports that. I'll try submitting a patch to enable BUILD_TESTING

make sense to me.

patch submitted in dartsim/dart#1819

@scpeters
Copy link
Member

ok, I didn't notice that it's also using FetchContent for pybind11, this will need an additional change upstream

@scpeters
Copy link
Member

ok, I didn't notice that it's also using FetchContent for pybind11, this will need an additional change upstream

or we can also set -DHOMEBREW_ALLOW_FETCHCONTENT=ON as a workaround for now

@jslee02
Copy link
Contributor

jslee02 commented Jun 26, 2024

ok, I didn't notice that it's also using FetchContent for pybind11, this will need an additional change upstream

DART_BUILD_DARTPY=OFF should prevent that

https://github.com/dartsim/dart/blob/5770b755f465c4d612bb602a410885bd64ab787a/python/CMakeLists.txt#L4-L15

@jslee02
Copy link
Contributor

jslee02 commented Jun 26, 2024

I would suggest adding -DBUILD_TESTING=OFF to just skip testing, but I don't think upstream supports that. I'll try submitting a patch to enable BUILD_TESTING

make sense to me.

patch submitted in dartsim/dart#1819

Merged and released 6.14.1 with this patch

@scpeters
Copy link
Member

I would suggest adding -DBUILD_TESTING=OFF to just skip testing, but I don't think upstream supports that. I'll try submitting a patch to enable BUILD_TESTING

make sense to me.

patch submitted in dartsim/dart#1819

Merged and released 6.14.1 with this patch

thanks @jslee02!

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 changed the title dartsim 6.14.0 dartsim 6.14.1 Jun 28, 2024
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jun 28, 2024
@chenrui333
Copy link
Member

Works for me in my local, thanks @scpeters @jslee02!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 28, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 28, 2024
Merged via the queue into master with commit caae97f Jun 28, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the bump-dartsim-6.14.0 branch June 28, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants