-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formula: trap CMake FetchContent usage instead of using FETCHCONTENT_FULLY_DISCONNECTED #17310
formula: trap CMake FetchContent usage instead of using FETCHCONTENT_FULLY_DISCONNECTED #17310
Conversation
Yeh, ideally there'd be a dedicated CMake variable for this
I think it's great! |
05fcc60
to
8e7bdbe
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh, this looks perfect, thanks again @alebcay!
8e7bdbe
to
7158fc7
Compare
Adjusted the scope of the conditional - we probably should just avoid creating the dependency provider altogether if we want to bypass. |
…FULLY_DISCONNECTED
7158fc7
to
920364c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks again @alebcay!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Follow-up to #17075. With this change, when a formula attempts to use
FetchContent_MakeAvailable
, the following error is presented:(This is using a modified version of the
cpr
formula to try the scenario whereFetchContent_MakeAvailable
gets used; normally this formula will rely on brewed dependencies.)Formulae can opt out by adding flag
-DCMAKE_PROJECT_TOP_LEVEL_INCLUDES=
(essentially unsetting the variable). Maybe we can provide something less unwieldy/better named to accomplish this.Seeking feedback especially about:
.cmake
file - for now I just dropped it inHOMEBREW_LIBRARY_PATH
, maybe it makes sense to be in some subdirectory, or in the Cellar somewhere (include this file in thecmake
formula/bottle rather than as part ofbrew
)