Repository navigation
Conversation
- Add jump links to different Prometheus flavors at top of page - Show all advanced options in YAML examples (commented out) - Add collapsible section with AI prompt to help users find Prometheus URL - Consolidate config explanations into inline comments - Add missing `query_response_size_limit_pct` option - Remove redundant sections and verbose explanations - Convert troubleshooting to concise table format - Fact-check defaults against source code Signed-off-by: Claude <noreply@anthropic.com>
✅ Deploy Preview for holmes-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughReworks Prometheus documentation into a unified, PromQL-focused toolset guide, replacing provider-specific blocks with a consolidated configuration and prompts, adding environment-variable alternatives, validation and “Finding your Prometheus URL” guidance, expanded options (headers, timeouts, cache, SSL, token limits), and reorganized provider guidance. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/data-sources/builtin-toolsets/prometheus.md`:
- Around line 45-53: Replace the current indented prompt block (the lines
starting with "I need to configure HolmesGPT to connect to Prometheus..." and
the "Run: kubectl get svc -A | grep -i prom" line) with an explicit fenced code
block using triple backticks and a language tag (e.g., ```text) so the entire
prompt and the kubectl command are enclosed between the opening and closing
fences to satisfy markdownlint.
🧹 Nitpick comments (1)
docs/data-sources/builtin-toolsets/prometheus.md (1)
30-33: Add blank line between bold label and list to satisfy MkDocs rendering.MkDocs won’t render lists correctly without a blank line after bold text. Please insert a blank line after each label before the list.
✅ Suggested edits
-**Environment variables** (alternative to config file): - -- `PROMETHEUS_URL`: Prometheus server URL -- `PROMETHEUS_AUTH_HEADER`: Authorization header value (e.g., `Bearer token123`) +**Environment variables** (alternative to config file): + +- `PROMETHEUS_URL`: Prometheus server URL +- `PROMETHEUS_AUTH_HEADER`: Authorization header value (e.g., `Bearer token123`) -**Setup:** - -1. Find your [regional PromQL endpoint](https://coralogix.com/docs/integrations/coralogix-endpoints/#promql) +**Setup:** + +1. Find your [regional PromQL endpoint](https://coralogix.com/docs/integrations/coralogix-endpoints/#promql) -**Notes:** - -- Automatically uses SigV4 authentication when `aws_region` is present +**Notes:** + +- Automatically uses SigV4 authentication when `aws_region` is present -**Prerequisites:** - -- Google Managed Prometheus enabled +**Prerequisites:** + +- Google Managed Prometheus enabled -**Setup:** - -1. Create service account token in Grafana Cloud (Administration → Service accounts) +**Setup:** + +1. Create service account token in Grafana Cloud (Administration → Service accounts)As per coding guidelines, add a blank line between bold text and a list in MkDocs docs.
Also applies to: 99-103, 126-130, 144-148, 165-169
- Resolve merge conflicts with master - Add new Azure Managed Prometheus section in concise format - Update jump links to include Azure - Add SSL error troubleshooting entry Signed-off-by: Claude <noreply@anthropic.com>
|
✅ Docker image ready for
Use this tag to pull the image for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:8c55aa7
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:8c55aa7 me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:8c55aa7
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:8c55aa7Patch Helm values in one line (choose the chart you use): HolmesGPT chart: helm upgrade --install holmesgpt ./helm/holmes \
--set registry=me-west1-docker.pkg.dev/robusta-development/development \
--set image=holmes-dev:8c55aa7Robusta wrapper chart: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.image=holmes-dev:8c55aa7 |
📂 Previous Runs📜 Run @ 2dfe3b9 (#21562639115)✅ Results of HolmesGPT evalsAutomatically triggered by commit 2dfe3b9 on branch Results of HolmesGPT evals
Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%. Historical Comparison DetailsFilter: excluding branch 'claude/concise-prometheus-docs-6Cf2q' Status: Success - 38 test/model combinations loaded Experiments compared (30):
Comparison indicators:
📜 Run @ 0de642b (#21492914216)✅ Results of HolmesGPT evalsAutomatically triggered by commit 0de642b on branch 📜 Run @ eda15df (#21485759258)✅ Results of HolmesGPT evalsAutomatically triggered by commit eda15df on branch 📜 Run @ 7d57365 (#21213417080)✅ Results of HolmesGPT evalsAutomatically triggered by commit 7d57365 on branch Results of HolmesGPT evals
Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%. Historical Comparison DetailsFilter: excluding branch 'claude/concise-prometheus-docs-6Cf2q' Status: Success - 25 test/model combinations loaded Experiments compared (30):
Comparison indicators:
✅ Results of HolmesGPT evalsAutomatically triggered by commit 4657f46 on branch Results of HolmesGPT evals
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line): Run evals on a different branch (e.g., master) for comparison:
Quick re-run: Use Option 2: Trigger via GitHub Actions UI → "Run workflow" 🏷️ Valid markers
Commands: CLI: |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/data-sources/builtin-toolsets/prometheus.md`:
- Around line 57-58: Add a blank line between the bold text line "**Port-forward
for testing:**" and the following code block delimiter "```bash" so the Markdown
renders correctly in MkDocs; update the section around that bold heading (the
bold line and the subsequent code fence) to include one empty line between them.
- Around line 64-65: Add a single blank line between the bold heading "**Get
internal cluster URL:**" and the following code block fence (```bash) so the
Markdown renderer (MkDocs) correctly treats the code block; update the section
in docs/data-sources/builtin-toolsets/prometheus.md by inserting an empty line
after the "**Get internal cluster URL:**" line.
🧹 Nitpick comments (1)
docs/data-sources/builtin-toolsets/prometheus.md (1)
72-72: Consider adjusting table pipe spacing for consistency.Markdownlint flags inconsistent spacing around table pipes. While this doesn't affect functionality, adding consistent spaces improves formatting consistency.
📋 Example fix for line 72
-|------|-------------| +| ----- | ----------- |Apply similar spacing adjustments to line 212.
Also applies to: 212-212
…etheus-docs-6Cf2q
….1:56810/git/HolmesGPT/holmesgpt into claude/concise-prometheus-docs-6Cf2q
…nal_headers - Restore yaml-toolset-config code fence for main config block - Use renamed additional_headers field (not headers) - Keep all concise improvements: jump links, commented-out advanced options, collapsible URL finder, AI prompt, troubleshooting table - Add missing query_response_size_limit_pct option Signed-off-by: Claude <noreply@anthropic.com>
- Keep original Prerequisites and Finding your Prometheus URL sections - Add Option 3 (Ask Holmes) to URL discovery - Use yaml-toolset-config fence and additional_headers throughout - Keep concise provider sections with commented-out advanced options Signed-off-by: Claude <noreply@anthropic.com>
🔬 CLI Performance Benchmark🟡 Startup Time (no LLM)Measures
🟡 Full CLI with LLMMeasures
PR: |
…etheus-docs-6Cf2q
There was a problem hiding this comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@docs/data-sources/builtin-toolsets/prometheus.md`:
- Around line 71-78: The fenced code block starting with ``` that contains the
kubectl command needs a language specifier to satisfy MD040: replace the opening
fence of the block (the triple backticks before "I need to configure
HolmesGPT...") with a language-tagged fence such as ```text; keep the block
content and closing ``` unchanged so the command and prompt remain intact.
The prompt can be pasted into any AI coding assistant (Claude Code, Cursor, etc.) without assuming a specific tool. Signed-off-by: Claude <noreply@anthropic.com>
Generates 3 tabs (Holmes CLI, Holmes Helm Chart, Robusta Helm Chart) for every provider config block, not just the main one. Signed-off-by: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@docs/data-sources/builtin-toolsets/prometheus.md`:
- Around line 69-82: The fenced code block inside the "??? tip \"Prompt for AI
agent\"" admonition is being treated as an indented code block (MD046); add an
explicit language tag to the opening fence to make it a fenced block (e.g.,
change the opening "```" to "```text" or "```bash") so the snippet under the
admonition in prometheus.md is recognized as fenced rather than indented; update
the opening fence for the block that begins with "I need to find my Prometheus
server URL..." accordingly.
Match master's pattern where setup instructions come before the YAML config block for Coralogix, Azure, Google, and Grafana Cloud. Signed-off-by: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/data-sources/builtin-toolsets/prometheus.md (1)
38-42: Optional: replace## Validationheader with bold text.
## Validationis a##-level section for a single one-liner command. Per coding guidelines, minor sections like test steps or examples should use bold text rather than Markdown headers.♻️ Proposed change
-## Validation - -```bash -holmes ask "Show me CPU usage for the last hour" -``` +**Validation:** + +```bash +holmes ask "Show me CPU usage for the last hour" +```As per coding guidelines: "don't create a header for every small section. For minor sections like test steps or examples, use bold text."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/data-sources/builtin-toolsets/prometheus.md` around lines 38 - 42, Replace the "## Validation" header with a bold inline label and adjust the following code block formatting: change the "## Validation" heading to "**Validation:**" and ensure the Bash example remains inside a fenced code block (```bash ... ```) as shown in the diff; update the markdown in docs/data-sources/builtin-toolsets/prometheus.md around the "Validation" section accordingly so it's a bold label plus the existing code example instead of a level-2 header.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@docs/data-sources/builtin-toolsets/prometheus.md`:
- Around line 69-82: The fenced code block inside the "Prompt for AI agent" tip
is missing a language tag, triggering markdownlint MD046; update the opening
fence (the triple backticks) to include a language identifier (e.g., ```text or
```bash) so the block is treated as a fenced code block; locate the
triple-backtick fence in the tip admonition (the block that begins with "I need
to find my Prometheus server URL...") and change the opening ``` to ```text (or
another appropriate language) and leave the closing ``` unchanged.
---
Nitpick comments:
In `@docs/data-sources/builtin-toolsets/prometheus.md`:
- Around line 38-42: Replace the "## Validation" header with a bold inline label
and adjust the following code block formatting: change the "## Validation"
heading to "**Validation:**" and ensure the Bash example remains inside a fenced
code block (```bash ... ```) as shown in the diff; update the markdown in
docs/data-sources/builtin-toolsets/prometheus.md around the "Validation" section
accordingly so it's a bold label plus the existing code example instead of a
level-2 header.
Signed-off-by: Claude <noreply@anthropic.com>
This branch has not been deployed
2 participants
query_response_size_limit_pctoptionSummary by CodeRabbit