Repository navigation
[ROB-2864] gcp docs update - #1268
Merged
Merged
Conversation
Signed-off-by: avi@robusta.dev <avi@robusta.dev>
Contributor
✅ Results of HolmesGPT evalsAutomatically triggered by commit 967ce9a Results of HolmesGPT evals
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line):
Option 2: Trigger via GitHub Actions UI → "Run workflow" 🏷️ Valid markers
📋 Valid eval names (use with filter)test_ask_holmes:
test_investigate:
|
Contributor
|
✅ Docker image ready for
Use this tag to pull the image for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:7c1d5db
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:7c1d5db me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:7c1d5db
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:7c1d5dbPatch Helm values in one line (choose the chart you use): HolmesGPT chart: helm upgrade --install holmesgpt ./helm/holmes \
--set registry=me-west1-docker.pkg.dev/robusta-development/development \
--set image=holmes-dev:7c1d5dbRobusta wrapper chart: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
--set holmes.image=holmes-dev:7c1d5db |
Contributor
WalkthroughAdds a "Google Managed Prometheus Configuration" section to the Prometheus data-source docs; the same block (prerequisites, YAML example, notes) is inserted twice in the file without removing or altering existing content. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)docs/**/*.md📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🪛 markdownlint-cli2 (0.18.1)docs/data-sources/builtin-toolsets/prometheus.md207-207: Link text should be descriptive (MD059, descriptive-link-text) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (2)
Comment |
Signed-off-by: avi@robusta.dev <avi@robusta.dev>
Contributor
✅ Results of HolmesGPT evalsAutomatically triggered by commit 75dd128 Results of HolmesGPT evals
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line):
Option 2: Trigger via GitHub Actions UI → "Run workflow" 🏷️ Valid markers
📋 Valid eval names (use with filter)test_ask_holmes:
test_investigate:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/data-sources/builtin-toolsets/prometheus.md
🧰 Additional context used
📓 Path-based instructions (1)
docs/**/*.md
📄 CodeRabbit inference engine (CLAUDE.md)
When writing documentation in the docs/ directory, always add a blank line between a header/bold text and a list, otherwise MkDocs won't render the list properly
Files:
docs/data-sources/builtin-toolsets/prometheus.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build
- GitHub Check: llm_evals
- GitHub Check: build (3.10)
- GitHub Check: build (3.12)
- GitHub Check: build (3.11)
🔇 Additional comments (1)
docs/data-sources/builtin-toolsets/prometheus.md (1)
200-229: Documentation structure follows MkDocs list-formatting guidelines.The new section correctly includes blank lines between headers/bold text and lists, ensuring proper MkDocs rendering per the coding guidelines.
Signed-off-by: avi@robusta.dev <avi@robusta.dev>
Contributor
✅ Results of HolmesGPT evalsAutomatically triggered by commit 00243d0 Results of HolmesGPT evals
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line):
Option 2: Trigger via GitHub Actions UI → "Run workflow" 🏷️ Valid markers
📋 Valid eval names (use with filter)test_ask_holmes:
test_investigate:
|
arikalon1
previously approved these changes
Dec 30, 2025
Signed-off-by: avi@robusta.dev <avi@robusta.dev>
Contributor
✅ Results of HolmesGPT evalsAutomatically triggered by commit 5d169ba Results of HolmesGPT evals
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line):
Option 2: Trigger via GitHub Actions UI → "Run workflow" 🏷️ Valid markers
📋 Valid eval names (use with filter)test_ask_holmes:
test_investigate:
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
docs/data-sources/builtin-toolsets/prometheus.md (1)
202-202: Update terminology to match project name.Line 202 reads "Before configuring Holmes" but should use the full project name "HolmesGPT" for consistency with the rest of the documentation.
🔎 Proposed fix
-Before configuring Holmes, make sure you have: +Before configuring HolmesGPT, make sure you have:
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/data-sources/builtin-toolsets/prometheus.md
🧰 Additional context used
📓 Path-based instructions (1)
docs/**/*.md
📄 CodeRabbit inference engine (CLAUDE.md)
When writing documentation in the docs/ directory, always add a blank line between a header/bold text and a list, otherwise MkDocs won't render the list properly
Files:
docs/data-sources/builtin-toolsets/prometheus.md
🪛 markdownlint-cli2 (0.18.1)
docs/data-sources/builtin-toolsets/prometheus.md
207-207: Link text should be descriptive
(MD059, descriptive-link-text)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: llm_evals
- GitHub Check: build (3.12)
- GitHub Check: build (3.11)
- GitHub Check: build (3.10)
🔇 Additional comments (1)
docs/data-sources/builtin-toolsets/prometheus.md (1)
200-226: No duplicate "Google Managed Prometheus Configuration" section exists in the file. The grep search found only one occurrence at line 200. The AI-generated summary indicating duplication was incorrect.
Signed-off-by: avi@robusta.dev <avi@robusta.dev>
Contributor
✅ Results of HolmesGPT evalsAutomatically triggered by commit cc1af7b Results of HolmesGPT evals
📖 Legend
🔄 Re-run evals manually
Option 1: Comment on this PR with Or with more options (one per line):
Option 2: Trigger via GitHub Actions UI → "Run workflow" 🏷️ Valid markers
📋 Valid eval names (use with filter)test_ask_holmes:
test_investigate:
|
moshemorad
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.