Copied mimir docs from robusta - #882
Conversation
WalkthroughUpdates Prometheus toolset documentation: adds a Capabilities section, removes a previous capabilities table under Coralogix config, introduces Grafana Cloud (Mimir) configuration steps and important notes, and clarifies proxy usage and metadata settings. No code or API changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant HolmesGPT
participant Proxy as Prometheus Proxy
participant Mimir as Grafana Cloud Prometheus/Mimir
Note over User,HolmesGPT: Pre-setup: Service account token (glsa_), datasource UID, proxy URL, headers configured
User->>HolmesGPT: Request metric query (instant/range)
HolmesGPT->>Proxy: Execute query (Authorization header, configured flags)
Proxy->>Mimir: Forward PromQL request
Mimir-->>Proxy: Query response (JSON)
Proxy-->>HolmesGPT: Response
HolmesGPT-->>User: Results
Note over HolmesGPT,Mimir: Metadata fetched via /series API (labels API disabled per config)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
docs/data-sources/builtin-toolsets/prometheus.md (2)
156-159: Add a blank line before the nested list to follow docs style and ensure consistent renderingPer docs guidelines, add a blank line between a bold line and a following list (here, a nested list).
-1. **Create a service account token in Grafana Cloud:** - - Navigate to "Administration → Service accounts" +1. **Create a service account token in Grafana Cloud:** + + - Navigate to "Administration → Service accounts" - Create a new service account - Generate a service account token (starts with `glsa_`)
175-180: Recommend adding a Mimir-ready healthcheckHelps the built-in healthcheck hit the correct readiness probe via Grafana’s proxy.
prometheus_url: https://YOUR-INSTANCE.grafana.net/api/datasources/proxy/uid/PROMETHEUS_DATASOURCE_UID + healthcheck: "/ready" # Recommended for Grafana Mimir via Grafana Cloud fetch_labels_with_labels_api: false # Important for Mimir fetch_metadata_with_series_api: true # Important for Mimir headers: - Authorization: Bearer YOUR_GLSA_TOKEN + Authorization: "{{ env.GRAFANA_CLOUD_TOKEN }}"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/data-sources/builtin-toolsets/prometheus.md(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/**/*.md
📄 CodeRabbit Inference Engine (CLAUDE.md)
In MkDocs docs, always add a blank line between a header/bold text and a following list
Files:
docs/data-sources/builtin-toolsets/prometheus.md
🪛 LanguageTool
docs/data-sources/builtin-toolsets/prometheus.md
[grammar] ~104-~104: There might be a mistake here.
Context: ...apabilities | Tool Name | Description | |-----------|-------------| | list_avail...
(QB_NEW_EN)
[grammar] ~105-~105: There might be a mistake here.
Context: ...escription | |-----------|-------------| | list_available_metrics | List all avai...
(QB_NEW_EN)
[grammar] ~106-~106: There might be a mistake here.
Context: ... List all available Prometheus metrics | | execute_prometheus_instant_query | Exe...
(QB_NEW_EN)
[grammar] ~107-~107: There might be a mistake here.
Context: ...uery | Execute an instant PromQL query | | execute_prometheus_range_query | Execu...
(QB_NEW_EN)
[grammar] ~108-~108: There might be a mistake here.
Context: ...ange PromQL query for time series data | | get_current_time | Get current timesta...
(QB_NEW_EN)
[grammar] ~156-~156: There might be a mistake here.
Context: ... service account token in Grafana Cloud:** - Navigate to "Administration → Service ac...
(QB_NEW_EN)
🪛 Gitleaks (8.27.2)
docs/data-sources/builtin-toolsets/prometheus.md
163-163: Discovered a potential authorization token provided in a curl command header, which could compromise the curl accessed resource.
(curl-auth-header)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Pre-commit checks
- GitHub Check: llm_evals
- GitHub Check: Pre-commit checks
🔇 Additional comments (1)
docs/data-sources/builtin-toolsets/prometheus.md (1)
102-110: Capabilities section looks goodClear, concise, and matches the toolset scope.
2 participants
Change from here robusta-dev/robusta@38a5795#diff-f7203e03e252047e645bcd4cf848cd5e71e401504b1ef3b66e51712cad3144f9L114