test: Wallet Service Facade initial tests by tuliomir · Pull Request #949 · HathorNetwork/hathor-wallet-lib

tuliomir · 2025-10-01T20:00:03Z

This PR is the immediate sequence to #909 , where the infrastructure to test the Wallet Service Facade was implemented.

Acceptance Criteria

Kickstart the Wallet Service facade suite with enough coverage for a good smoke test
Implement a solution for frequent socket hang up errors while requesting the serverless-offline environment

Notes

Nano Contracts were not tested in this PR
WebSockets were also not tested and are still lacking coverage
The tests here are not complete because the priority for now is test: Shared integration test code between facades #947
Various improvements of code style will also be implemented by 947. Those improvements require Typescript typing that demands a larger scope of refactoring than this PR would accomodate.
We tried removing the --forceExit from the integration tests as it was expected that it would have been solved by feat: do not start background tasks during tests #934 , but the CI didn't pass without it, so we just moved this flag to the Jest configs instead.

Security Checklist

Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

codecov · 2025-10-01T20:02:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.62%. Comparing base (21ba6c1) to head (293a581).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
+ Coverage   85.00%   86.62%   +1.62%     
==========================================
  Files         113      113              
  Lines        8389     8396       +7     
  Branches     1832     1834       +2     
==========================================
+ Hits         7131     7273     +142     
+ Misses       1229     1096     -133     
+ Partials       29       27       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 12 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-10T23:32:07Z

src/wallet/wallet.ts

+      this.retryConfig = {
+        maxRetries: retryConfig.maxRetries,
+        delayBaseMs: retryConfig.delayBaseMs,
+        delayMaxMs: retryConfig.delayMaxMs,
+      };


The retry configuration is being copied property by property rather than using object spread or a more concise approach. This creates unnecessary code repetition. Consider simplifying to this.retryConfig = { ...retryConfig }; which achieves the same result with less code and is more maintainable.

Suggested change

this.retryConfig = {

maxRetries: retryConfig.maxRetries,

delayBaseMs: retryConfig.delayBaseMs,

delayMaxMs: retryConfig.delayMaxMs,

};

this.retryConfig = { ...retryConfig };

For now we'd rather have this property being copied item by item, but this is a good improvement once we settle on a definitive design for this retryConfig.

src/wallet/api/walletApi.ts

Copilot · 2025-12-10T23:32:09Z

__tests__/integration/walletservice_facade.test.ts

+      // @ts-expect-error - tokenOutput must exist
+      expect(tokenOutput).toStrictEqual(
+        expect.objectContaining({
+          value: tokenAmount,
+          tokenData: 1,
+          script: expect.any(Buffer),
+        })
+      );


Using @ts-expect-error to suppress type errors for variables that "must exist" indicates a type safety gap. Consider using non-null assertion (tokenOutput!) or restructuring the code to properly handle the case where these outputs might not be found, either with explicit null checks and error throws, or by using find() with proper type guards.

These issues will be solved soon, with the Shared Tests PR.
For now we'll have to rely on those typescript adjustments.

__tests__/integration/walletservice_facade.test.ts

src/wallet/api/walletServiceAxios.ts

__tests__/integration/walletservice_facade.test.ts

andreabadesso · 2025-12-11T20:46:45Z

src/wallet/api/walletApi.ts

 import HathorWalletServiceWallet from '../wallet';
 import { WalletRequestError, TxNotFoundError } from '../../errors';
 import { parseSchema } from '../../utils/bigint';
+import helpers from '../../utils/helpers';


Thanks, removed on 64f43d0

andreabadesso · 2025-12-11T20:47:55Z

src/wallet/api/walletApi.ts

+    // we pass the response data to the guard for additional validations.
+    if (response.status === 404 && response.data) {
+      walletApi._txNotFoundGuard(response.data);
+      throw new WalletRequestError('Error getting transaction by its id.', {


Remove this throw? We already have it down there?

Good catch, this was an obsolete validation. Removed on 64f43d0

andreabadesso · 2025-12-11T20:48:44Z

src/wallet/wallet.ts

+    try {
+      const sign = this.signMessage(privKey, timestamp, this.walletId);
+      const data = await walletApi.createAuthToken(this, timestamp, privKey.xpubkey, sign);


I don't get it... Is this a fix? Why are you try/catching it? Maybe add a log?

Yes, it's a fix!
We were having errors without any relation to whatever was being tested because this function runs asynchronously and crashes when the original caller context had already been fully finished.

Added a console on 9b045be

This reverts commit 9b045be.

tuliomir added 11 commits October 1, 2025 16:38

chore: improvements to config

907bdb6

chore: typing the test logger

0636e75

chore: adapts walletApi to serverless response

34e5e87

test: helper functions and structure

1b27201

test: start tests

1fc3121

test: wallet public method tests

2f64536

test: empty wallet address tests

b3ab813

test: basic transaction tests

2bc52a0

test: balance tests

2fdd1bb

test: addresses with tx tests

8d2cecc

test: utxo tests

3fcbe56

tuliomir self-assigned this Oct 1, 2025

tuliomir added this to Hathor Network Oct 1, 2025

tuliomir requested a review from pedroferreira1 as a code owner October 1, 2025 20:00

tuliomir added the tests label Oct 1, 2025

github-project-automation bot moved this to Todo in Hathor Network Oct 1, 2025

tuliomir moved this from Todo to In Progress (WIP) in Hathor Network Oct 1, 2025

tuliomir added 6 commits October 2, 2025 12:46

fix: incorrect imports not from source

1e71119

feat: retries requests on wallet service tests

d154fa3

feat: retries wallet-not-found errors

4bac4ef

fix: import delay fn

34b09c3

fix: failing tests

cf7ef69

fix: unhandled promises

c728b35

tuliomir force-pushed the test/not-websocket branch from 1b39152 to c728b35 Compare October 6, 2025 23:44

tuliomir moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Oct 7, 2025

tuliomir moved this from In Progress (Done) to In Progress (WIP) in Hathor Network Oct 7, 2025

tuliomir added 2 commits October 7, 2025 09:41

refactor: removes unnecessary consoles

7ed3eed

fix: pooling logic

5fb57c7

tuliomir moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Oct 7, 2025

tuliomir requested a review from andreabadesso December 8, 2025 16:47

tuliomir mentioned this pull request Dec 9, 2025

chore: Compatibility with fee based tokens HathorNetwork/hathor-wallet-service#330

Closed

3 tasks

tuliomir added 5 commits December 9, 2025 18:28

fix: optional token version

7364dda

fix: token details response schema

d325729

refactor: retryConfig instead of slowWallets

baa1ad5

chore: improves criteria for retrying

3e04c55

docs: removes logging

363390e

tuliomir requested review from Copilot and r4mmer December 10, 2025 23:27

Copilot started reviewing on behalf of tuliomir December 10, 2025 23:28 View session

Copilot AI reviewed Dec 10, 2025

View reviewed changes

tuliomir added 4 commits December 10, 2025 20:35

refactor: moves default values to constants

575f590

docs: improves wording

cbb189a

chore: disables keep-alive in axios for tests

bfe2527

chore: removes retry logic

af85127

andreabadesso reviewed Dec 11, 2025

View reviewed changes

tuliomir added 2 commits December 12, 2025 12:13

chore: removes obsolete code

64f43d0

chore: adds error console on async auth token fail

9b045be

tuliomir requested a review from andreabadesso December 12, 2025 15:23

andreabadesso previously approved these changes Dec 12, 2025

View reviewed changes

Revert "chore: adds error console on async auth token fail"

7d5f45c

This reverts commit 9b045be.

tuliomir dismissed andreabadesso’s stale review via 7d5f45c December 12, 2025 16:54

fix: restores 404 validation

293a581

andreabadesso approved these changes Dec 12, 2025

View reviewed changes

r4mmer approved these changes Dec 12, 2025

View reviewed changes

tuliomir merged commit c832bb3 into master Dec 12, 2025
5 checks passed

github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Dec 12, 2025

tuliomir deleted the test/not-websocket branch December 12, 2025 18:53

tuliomir moved this from Waiting to be deployed to Done in Hathor Network Jan 26, 2026

tuliomir mentioned this pull request Mar 9, 2026

feat: wallet start tests #929

Closed

1 task

Conversation

tuliomir commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Acceptance Criteria

Notes

Security Checklist

Uh oh!

codecov bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tuliomir commented Oct 1, 2025 •

edited

Loading

codecov bot commented Oct 1, 2025 •

edited

Loading