Skip to content

test: Wallet Service infrastructure#909

Merged
tuliomir merged 26 commits intomasterfrom
test/wallet-service
Sep 30, 2025
Merged

test: Wallet Service infrastructure#909
tuliomir merged 26 commits intomasterfrom
test/wallet-service

Conversation

@tuliomir
Copy link
Copy Markdown
Contributor

@tuliomir tuliomir commented Aug 27, 2025 •
edited
Loading

Acceptance Criteria

  • We should have the infrastructure in place to test the Wallet Service facade
  • We should have one green test in the suite: a 200 response from the /version endpoint

Note

The Wallet Service repository has only recently implemented the Docker images, a feature needed by this PR.
This was done by HathorNetwork/hathor-wallet-service#283 .

Other development notes

To avoid unnecessary block validation delays in this early stage of development, comment out the block waiting commands in the setup tests and run the tests only in the new file by using the SPECIFIC_INTEGRATION_TEST_FILE=walletservice_facade environment variable.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir self-assigned this Aug 27, 2025
@tuliomir tuliomir added the tests label Aug 27, 2025
@tuliomir tuliomir moved this from Todo to In Progress (WIP) in Hathor Network Aug 27, 2025
tuliomir
tuliomir commented Aug 27, 2025
View reviewed changes
@tuliomir tuliomir mentioned this pull request Aug 27, 2025
Merged
3 tasks
@tuliomir
wip: only ws-daemon container doesnt run
a0eeb41
@tuliomir
wip: working container, broken sql
5df32a5
@tuliomir
feat: adds migration argument to build
a58d7c7
@tuliomir
fix: migrator now its own container
3e569a4
@tuliomir
fix: fullnode configs
c30c142
@tuliomir
feat: dynamic fullnode ids for daemon
5d16d5d
@tuliomir
feat: dynamic fullnode ids for daemon
eae48dc
@tuliomir
wip: placeholder env variables for the serverless
0013234
@tuliomir
fix: serverless build context
a93b9a1
@tuliomir
wip: initial tests
0804f95
@tuliomir
fix: removes hardcoded build context
df649c8 
This will be completely removed as soon as we have the actual images being built and published
@tuliomir
refactor: removes unnecessary debug code
5d7b811
@tuliomir
fix: fullnode port for ws-serverless
be12e71
@tuliomir
feat: improvements on the docker compose
5b9b1fe
@tuliomir
revert: ws-migrator is still needed
09f8a77
@tuliomir
docs: improves compose comments
c3aed28
@tuliomir
refactor: uses wallet service images instead of builds
421640a
@tuliomir tuliomir force-pushed the test/wallet-service branch from b5aec13 to 421640a Compare September 1, 2025 17:19
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.54%. Comparing base (08a726f) to head (0a39781).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #909   +/-   ##
=======================================
  Coverage   84.54%   84.54%           
=======================================
  Files         111      111           
  Lines        7991     7991           
  Branches     1712     1721    +9     
=======================================
  Hits         6756     6756           
  Misses       1207     1207           
  Partials       28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tuliomir
tuliomir commented Sep 2, 2025
View reviewed changes
__tests__/integration/configuration/docker-compose.yml
mysql:
condition: service_healthy
ws-daemon:
condition: service_started # TODO: Implement healthcheck
Copy link
Copy Markdown
Contributor Author

@tuliomir tuliomir Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as we have an initial version published, those important improvements can be worked upon

@tuliomir tuliomir moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Sep 3, 2025
luislhl
luislhl reviewed Sep 4, 2025
View reviewed changes
tuliomir
tuliomir commented Sep 24, 2025
View reviewed changes
.github/workflows/integration-test.yml
itest:
runs-on: 'ubuntu-latest'
timeout-minutes: 40
timeout-minutes: 50
Copy link
Copy Markdown
Contributor Author

@tuliomir tuliomir Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests were timing out and this period had to be increased

@tuliomir tuliomir marked this pull request as ready for review September 25, 2025 16:26
@tuliomir tuliomir requested a review from luislhl September 25, 2025 16:28
@tuliomir tuliomir moved this from In Progress (Done) to In Review (WIP) in Hathor Network Sep 30, 2025
@luislhl luislhl moved this from In Review (WIP) to In Review (Done) in Hathor Network Sep 30, 2025
@tuliomir tuliomir merged commit b8582db into master Sep 30, 2025
5 of 6 checks passed
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Sep 30, 2025
@tuliomir tuliomir deleted the test/wallet-service branch September 30, 2025 16:36
@tuliomir tuliomir mentioned this pull request Oct 1, 2025
Merged
1 task
@tuliomir tuliomir moved this from Waiting to be deployed to Done in Hathor Network Oct 2, 2025
r4mmer added a commit that referenced this pull request Dec 11, 2025
@r4mmer
Merge remote-tracking branch 'origin/master' into feat/single-address…
a1da3e3 
…-policy

* origin/master: (31 commits)
  feat: fee token creation (#858)
  fix: checkAddressMine was crashing when called with an empty array (#977)
  feat: the nano amount field should accept 0
  Merge pull request #975 from HathorNetwork/chore/bump-v2.11.0
  feat: add nano execution logs API (#973)
  Refactor: Fullnode facade to Typescript (#972)
  Merge pull request #970 from HathorNetwork/chore/bump-v2.10.0
  fix: added missing tx proposal delete schema (#969)
  feat: add missing api calls for graphviz and nano (#967)
  Merge pull request #965 from HathorNetwork/feat/complete-token-info-object
  chore: bump package to v2.9.1 (#962)
  feat: catch and store async promise error (#960)
  chore: bump wallet lib to v2.9.0 (#958)
  tests: use core v0.67.0 docker image for the integration tests (#956)
  tests: update integration tests blueprints for the new core sdk (#954)
  fix: added a minimal accessData so methods that need storage don't crash (#955)
  feat: fee header (#951)
  feat: added read-only start (#950)
  fix: dont add metadata changed for voided txs (#948)
  test: Wallet Service infrastructure (#909)
  ...
@tuliomir tuliomir mentioned this pull request Mar 19, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreabadesso andreabadesso andreabadesso approved these changes

@luislhl luislhl luislhl approved these changes

@pedroferreira1 pedroferreira1 Awaiting requested review from pedroferreira1 pedroferreira1 is a code owner

Assignees

@tuliomir tuliomir

Labels

tests

Projects

Hathor Network
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tuliomir @andreabadesso @luislhl