Skip to content

feat: do not start background tasks during tests#934

Merged
r4mmer merged 5 commits intomasterfrom
feat/stop-bg-task
Sep 19, 2025
Merged

feat: do not start background tasks during tests#934
r4mmer merged 5 commits intomasterfrom
feat/stop-bg-task

Conversation

@r4mmer
Copy link
Copy Markdown
Member

@r4mmer r4mmer commented Sep 16, 2025

Acceptance Criteria

  • Allow the user to stop the GLL background task that may keep integration tests hanging.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.44%. Comparing base (d636422) to head (62bbda5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #934       +/-   ##
===========================================
+ Coverage   57.22%   84.44%   +27.22%     
===========================================
  Files         111      111               
  Lines        7974     7978        +4     
  Branches     1704     1714       +10     
===========================================
+ Hits         4563     6737     +2174     
+ Misses       3394     1215     -2179     
- Partials       17       26        +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tuliomir
tuliomir previously approved these changes Sep 17, 2025
@tuliomir tuliomir moved this from Todo to In Review (WIP) in Hathor Network Sep 17, 2025
@r4mmer r4mmer removed the request for review from pedroferreira1 September 17, 2025 15:42
andreabadesso
andreabadesso previously approved these changes Sep 19, 2025
@r4mmer r4mmer dismissed stale reviews from tuliomir and andreabadesso via 62bbda5 September 19, 2025 12:45
@r4mmer r4mmer moved this from In Review (WIP) to In Progress (Done) in Hathor Network Sep 19, 2025
@tuliomir tuliomir moved this from In Progress (Done) to In Review (WIP) in Hathor Network Sep 19, 2025
@r4mmer r4mmer merged commit 6874464 into master Sep 19, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Sep 19, 2025
@r4mmer r4mmer deleted the feat/stop-bg-task branch September 19, 2025 18:06
@r4mmer r4mmer moved this from Waiting to be deployed to Done in Hathor Network Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants