Skip to content

chore: Container builds#283

Merged
tuliomir merged 46 commits intomasterfrom
chore/container-builds
Sep 23, 2025
Merged

chore: Container builds#283
tuliomir merged 46 commits intomasterfrom
chore/container-builds

Conversation

@tuliomir
Copy link
Copy Markdown
Contributor

@tuliomir tuliomir commented Aug 27, 2025

Motivation

We need a way to run the Wallet Service inside a containerized environment containing a live and pristine blockchain privatenet. The first usage of this feature is being developed in HathorNetwork/hathor-wallet-lib#909

Acceptance Criteria

  • Both the Daemon and the Wallet Service packages need independent Docker images
  • There should be a way to run the migrations in the pristine MySQL instance before the Daemon container is started. For now, a third Docker image is created for the sole purpose of running the migrations.
  • There should be solutions for the currently necessary connections to external services such as AWS, Firebase and other third parties. For now, they are being mocked.

Notes

Although it's very important to automatically build all three images with every CI/CD deployment, this feature is not meant to be implemented now. The main objective of this PR is to have viable images for the integration tests on the Lib 909 mentioned above.

As soon as we have this infrastructure well tested, we'll begin work on the CD phase. For now, the Docker images will have to be published manually.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir self-assigned this Aug 27, 2025
@tuliomir tuliomir changed the title Chore/container builds chore: Container builds Aug 27, 2025
@tuliomir tuliomir moved this from Todo to In Progress (WIP) in Hathor Network Aug 27, 2025
@tuliomir tuliomir requested review from luislhl and removed request for pedroferreira1 September 3, 2025 00:04
@tuliomir tuliomir moved this from In Progress (WIP) to In Progress (Done) in Hathor Network Sep 3, 2025
@tuliomir tuliomir force-pushed the chore/container-builds branch from 5ef6433 to 2bbd9f2 Compare September 9, 2025 15:34
@tuliomir tuliomir moved this from In Review (Done) to In Progress (Done) in Hathor Network Sep 9, 2025
luislhl
luislhl previously approved these changes Sep 9, 2025
@tuliomir tuliomir moved this from In Progress (Done) to In Review (WIP) in Hathor Network Sep 10, 2025
luislhl
luislhl previously approved these changes Sep 17, 2025
Comment thread packages/wallet-service/Dockerfile.dev
@tuliomir tuliomir force-pushed the chore/container-builds branch from b6c8eef to f6546e2 Compare September 22, 2025 18:39
@tuliomir tuliomir requested a review from luislhl September 22, 2025 22:48
@luislhl luislhl moved this from In Review (WIP) to In Review (Done) in Hathor Network Sep 23, 2025
@tuliomir tuliomir merged commit 459b0fd into master Sep 23, 2025
1 check passed
@github-project-automation github-project-automation Bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Sep 23, 2025
@tuliomir tuliomir deleted the chore/container-builds branch September 23, 2025 13:18
@tuliomir tuliomir moved this from Waiting to be deployed to Done in Hathor Network Sep 29, 2025
This was referenced Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants