fix: promise leak by capturing rejection from getVersion#584
Merged
alexruzenhack merged 2 commits intodevfrom Oct 31, 2023
Merged
fix: promise leak by capturing rejection from getVersion#584alexruzenhack merged 2 commits intodevfrom
alexruzenhack merged 2 commits intodevfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #584 +/- ##
=======================================
Coverage 64.86% 64.86%
=======================================
Files 67 67
Lines 5254 5254
Branches 1108 1108
=======================================
Hits 3408 3408
Misses 1766 1766
Partials 80 80
☔ View full report in Codecov by Sentry. |
7fc4c70 to
447c8d0
Compare
Contributor
447c8d0 to
7ca39b0
Compare
1 task
pedroferreira1
approved these changes
Oct 27, 2023
r4mmer
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Related to: HathorNetwork/hathor-wallet-mobile#364
Security Checklist