feat: support health-check endpoints on hathor-core and tx-mining-service#579
feat: support health-check endpoints on hathor-core and tx-mining-service#579
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #579 +/- ##
===========================================
+ Coverage 64.82% 78.51% +13.69%
===========================================
Files 67 68 +1
Lines 5257 5270 +13
Branches 1108 1108
===========================================
+ Hits 3408 4138 +730
+ Misses 1769 1117 -652
+ Partials 80 15 -65
☔ View full report in Codecov by Sentry. |
| */ | ||
| async getHealth() { | ||
| return new Promise((resolve, reject) => { | ||
| // TODO: We should chage this to get `health` instead of `version` |
There was a problem hiding this comment.
This depends on HathorNetwork/hathor-core#807
There was a problem hiding this comment.
This was merged a week ago. Has it been released already?
luislhl
changed the title
tuliomir
left a comment
tuliomir
left a comment
There was a problem hiding this comment.
The code looks good to me, but it will be necessary to implement unit tests on those new methods for the CI to pass.
luislhl
force-pushed
the
feat/health-check-support
branch
from
ddd34cf to
eaf26e5
Compare
tuliomir
left a comment
tuliomir
left a comment
There was a problem hiding this comment.
🌟 Great organization for the unit tests.
Also, the async wrapper for getVersion will be quite useful for improving the wallet clients too.
| */ | ||
| async getHealth() { | ||
| return new Promise((resolve, reject) => { | ||
| // TODO: We should chage this to get `health` instead of `version` |
There was a problem hiding this comment.
This was merged a week ago. Has it been released already?
luislhl
force-pushed
the
feat/health-check-support
branch
from
ea88727 to
ea5e749
Compare
3 participants
Acceptance Criteria
Note: The health endpoint in hathor-core is still being developed in HathorNetwork/hathor-core#807. When it's released and available on most fullnodes, we will create a new PR to use it in the wallet-lib.
Security Checklist