Skip to content

fix: promise leak by capturing rejection from getVersion #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexruzenhack merged 2 commits into from
Oct 31, 2023
Merged

fix: promise leak by capturing rejection from getVersion #584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ca39b0
fix: promise leak by capturing rejection from getVersion
alexruzenhack Oct 26, 2023
1a1ef76
chore: add semicolon in the end of instruction
alexruzenhack Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/new/wallet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@ class HathorWallet extends EventEmitter {
* @inner
**/
async getVersionData() {
const versionData = await new Promise(resolve => {
versionApi.getVersion(resolve)
const versionData = await new Promise((resolve, reject)=> {
versionApi.getVersion(resolve).catch((error) => reject(error));
});

return {
Expand Down Expand Up @@ -1312,8 +1312,8 @@ class HathorWallet extends EventEmitter {
this.walletStopped = false;
this.setState(HathorWallet.CONNECTING);

const info = await new Promise(resolve => {
versionApi.getVersion(resolve);
const info = await new Promise((resolve , reject)=> {
versionApi.getVersion(resolve).catch((error) => reject(error));
});
if (info.network.indexOf(this.conn.network) >= 0) {
this.storage.setApiVersion(info);
Expand Down