Skip to content

fix(feature-activation): add missing metadata migration#927

Merged
glevco merged 1 commit intomasterfrom
fix/feature-activation/add-missing-migration
Jan 29, 2024
Merged

fix(feature-activation): add missing metadata migration#927
glevco merged 1 commit intomasterfrom
fix/feature-activation/add-missing-migration

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jan 16, 2024

Motivation

The feature activation bit counts metadata would be empty causing a max recursion error due to a change caused by #785.

Acceptance Criteria

  • Add bit counts calculation in update_initial_metadata().
  • Add add_feature_activation_bit_counts_metadata2 migration.
  • Change add_feature_activation_bit_counts_metadata migration so it does nothing.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the bug Something isn't working label Jan 16, 2024
@glevco glevco self-assigned this Jan 16, 2024
@glevco glevco force-pushed the fix/feature-activation/add-missing-migration branch from 4ca4fb1 to f0fa240 Compare January 16, 2024 21:45
@glevco glevco marked this pull request as ready for review January 16, 2024 21:45
@codecov
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2be371f) 85.25% compared to head (bbcd88a) 85.34%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ons/add_feature_activation_bit_counts_metadata2.py 68.75% 5 Missing ⚠️
...ions/add_feature_activation_bit_counts_metadata.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
+ Coverage   85.25%   85.34%   +0.09%     
==========================================
  Files         288      289       +1     
  Lines       22397    22416      +19     
  Branches     3373     3374       +1     
==========================================
+ Hits        19094    19131      +37     
+ Misses       2625     2614      -11     
+ Partials      678      671       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the fix/feature-activation/add-missing-migration branch from 9ef629f to d5306f4 Compare January 26, 2024 15:45
@glevco glevco force-pushed the fix/feature-activation/add-missing-migration branch from d5306f4 to bbcd88a Compare January 29, 2024 02:17
@glevco glevco merged commit b6748ee into master Jan 29, 2024
@glevco glevco deleted the fix/feature-activation/add-missing-migration branch January 29, 2024 03:20
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants