fix(feature-activation): add missing metadata migration#927
Merged
Conversation
4ca4fb1 to
f0fa240
Compare
jansegre
approved these changes
Jan 16, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #927 +/- ##
==========================================
+ Coverage 85.25% 85.34% +0.09%
==========================================
Files 288 289 +1
Lines 22397 22416 +19
Branches 3373 3374 +1
==========================================
+ Hits 19094 19131 +37
+ Misses 2625 2614 -11
+ Partials 678 671 -7 ☔ View full report in Codecov by Sentry. |
08b2671 to
9ef629f
Compare
This was referenced Jan 23, 2024
msbrogli
approved these changes
Jan 25, 2024
hathor/transaction/storage/migrations/add_feature_activation_bit_counts_metadata2.py
Show resolved
Hide resolved
9ef629f to
d5306f4
Compare
d5306f4 to
bbcd88a
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The feature activation bit counts metadata would be empty causing a max recursion error due to a change caused by #785.
Acceptance Criteria
update_initial_metadata().add_feature_activation_bit_counts_metadata2migration.add_feature_activation_bit_counts_metadatamigration so it does nothing.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged