Skip to content

chore(feature-activation): phased testing adjustments#931

Merged
glevco merged 1 commit intomasterfrom
chore/feature-activation/testnet-adjustments
Jan 30, 2024
Merged

chore(feature-activation): phased testing adjustments#931
glevco merged 1 commit intomasterfrom
chore/feature-activation/testnet-adjustments

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jan 23, 2024

Depends on #927

Motivation

Clean up Phased Testing artifacts from testnet, so we can update its Evaluation Interval from 2 weeks to 1 week, making it the same as mainnet.

Acceptance Criteria

  • Remove NOP feature configs from testnet config files.
  • Update the testnet Evaluation Interval from 40320 to 20160 blocks (1 week), so it's the same as mainnet.
  • Update the testnet default threshold to 15120 blocks (75% of the Evaluation Interval).
  • Fix NOP feature logging in HathorManager to support mainnet features.
  • Add a migration to clean testnet Phased Testing metadata.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jan 23, 2024
@glevco glevco force-pushed the chore/feature-activation/testnet-adjustments branch from 72eebed to 5029a38 Compare January 23, 2024 00:35
@glevco glevco marked this pull request as ready for review January 23, 2024 01:02
jansegre
jansegre previously approved these changes Jan 23, 2024
msbrogli
msbrogli previously approved these changes Jan 25, 2024
@glevco glevco force-pushed the fix/feature-activation/add-missing-migration branch 2 times, most recently from d5306f4 to bbcd88a Compare January 29, 2024 02:17
Base automatically changed from fix/feature-activation/add-missing-migration to master January 29, 2024 03:20
@glevco glevco dismissed stale reviews from msbrogli and jansegre January 29, 2024 03:20

The base branch was changed.

@glevco glevco force-pushed the chore/feature-activation/testnet-adjustments branch from 5029a38 to bc3dfca Compare January 29, 2024 03:22
@codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (b6748ee) 85.37% compared to head (bc3dfca) 85.33%.

Files Patch % Lines
...n/storage/migrations/remove_second_nop_features.py 52.17% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
- Coverage   85.37%   85.33%   -0.04%     
==========================================
  Files         289      290       +1     
  Lines       22416    22437      +21     
  Branches     3374     3377       +3     
==========================================
+ Hits        19138    19147       +9     
- Misses       2608     2621      +13     
+ Partials      670      669       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco merged commit 94d29e3 into master Jan 30, 2024
@glevco glevco deleted the chore/feature-activation/testnet-adjustments branch January 30, 2024 04:48
@jansegre jansegre mentioned this pull request Jan 30, 2024
2 tasks
@jansegre jansegre mentioned this pull request Feb 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants