Skip to content

feat(feature-activation): implement closest_block metadata and Feature Activation for Transactions#933

Merged
glevco merged 1 commit intomasterfrom
feat/feature-activation/txs-closest-block
Nov 7, 2024
Merged

feat(feature-activation): implement closest_block metadata and Feature Activation for Transactions#933
glevco merged 1 commit intomasterfrom
feat/feature-activation/txs-closest-block

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jan 23, 2024

Depends on #1150

Motivation

Implement the new closest_ancestor_block static metadata and Feature Activation for Transactions.

Acceptance Criteria

  • Create new closest_ancestor_block static metadata for Transactions.
  • Implement Feature Activation for Transactions.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.70%. Comparing base (487e731) to head (9e0bbd8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...n/storage/migrations/add_closest_ancestor_block.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
- Coverage   84.74%   84.70%   -0.05%     
==========================================
  Files         313      314       +1     
  Lines       24288    24335      +47     
  Branches     3701     3708       +7     
==========================================
+ Hits        20584    20613      +29     
- Misses       2989     3003      +14     
- Partials      715      719       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the fix/feature-activation/add-missing-migration branch 2 times, most recently from d5306f4 to bbcd88a Compare January 29, 2024 02:17
Base automatically changed from fix/feature-activation/add-missing-migration to master January 29, 2024 03:20
@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch from d3d069c to 44fd304 Compare July 16, 2024 16:51
@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch from 44fd304 to 0b47ad8 Compare August 6, 2024 20:40
@glevco glevco changed the base branch from master to refactor/metadata/migrate-feature-states-5 August 6, 2024 20:41
@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch 2 times, most recently from e02430f to 60d55f7 Compare August 6, 2024 21:37
@glevco glevco force-pushed the refactor/metadata/migrate-feature-states-5 branch 2 times, most recently from 162cc89 to 360c3e9 Compare August 12, 2024 19:36
@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch from 60d55f7 to dc5d25a Compare August 12, 2024 23:32
@glevco glevco force-pushed the refactor/metadata/migrate-feature-states-5 branch 6 times, most recently from ca910a0 to a904b3f Compare August 19, 2024 19:10
@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch 3 times, most recently from 33b9cce to d1dfbcd Compare August 19, 2024 19:43
@glevco glevco force-pushed the refactor/settings/wallets-and-reward-lock branch 2 times, most recently from b8c3f63 to 7048b1d Compare October 11, 2024 16:54
@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch from 8336796 to 5218068 Compare October 11, 2024 16:55
@glevco glevco force-pushed the refactor/settings/wallets-and-reward-lock branch from 7048b1d to 82f8e5d Compare October 14, 2024 03:43
@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch from 5218068 to 9c57c6f Compare October 14, 2024 03:57
jansegre
jansegre previously approved these changes Oct 14, 2024
@glevco glevco force-pushed the refactor/settings/wallets-and-reward-lock branch from 82f8e5d to 391c9f0 Compare October 17, 2024 13:49
@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch from 9c57c6f to 32a353c Compare October 17, 2024 13:52
Base automatically changed from refactor/settings/wallets-and-reward-lock to master October 17, 2024 17:56
@glevco glevco dismissed jansegre’s stale review October 17, 2024 17:56

The base branch was changed.

@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch from 32a353c to f1cfe85 Compare October 17, 2024 17:59
@github-actions
Copy link

github-actions bot commented Oct 17, 2024

🐰 Bencher Report

Branchfeat/feature-activation/txs-closest-block
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Lower Boundary
nanoseconds (ns)
(Limit %)
Upper Boundary
nanoseconds (ns)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
101,431,247,981.12
(-0.35%)
91,610,742,762.21
(90.32%)
111,968,685,598.25
(90.59%)
🐰 View full continuous benchmarking report in Bencher

jansegre
jansegre previously approved these changes Oct 18, 2024
msbrogli
msbrogli previously approved these changes Oct 18, 2024
@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch from f1cfe85 to aacdccf Compare October 18, 2024 19:23
@glevco glevco changed the base branch from master to chore/remove-features October 22, 2024 14:38
@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch from aacdccf to 2b0a2b8 Compare October 22, 2024 14:41
@glevco glevco force-pushed the chore/remove-features branch from ba93884 to 65cec01 Compare October 23, 2024 20:23
@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch from 2b0a2b8 to cc58e5f Compare October 23, 2024 20:27
@glevco glevco force-pushed the chore/remove-features branch from 65cec01 to 269e7a1 Compare October 25, 2024 13:20
@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch from cc58e5f to e85056d Compare October 27, 2024 21:21
Base automatically changed from chore/remove-features to master October 29, 2024 15:39
@glevco glevco dismissed stale reviews from jansegre and msbrogli October 29, 2024 15:39

The base branch was changed.

@glevco glevco force-pushed the feat/feature-activation/txs-closest-block branch from e85056d to dba3ba3 Compare November 4, 2024 18:58
@jansegre jansegre mentioned this pull request Nov 21, 2024
2 tasks
@jansegre jansegre mentioned this pull request Dec 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants