refactor(settings): change daa to use injected settings#801
Merged
Conversation
This was referenced Sep 29, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #801 +/- ##
==========================================
- Coverage 85.06% 85.02% -0.05%
==========================================
Files 275 271 -4
Lines 22502 22380 -122
Branches 3434 3419 -15
==========================================
- Hits 19142 19029 -113
- Misses 2674 2676 +2
+ Partials 686 675 -11
☔ View full report in Codecov by Sentry. |
jansegre
previously approved these changes
Oct 6, 2023
9145c97 to
7093fa5
Compare
09ee92f to
c76fb12
Compare
ca40831 to
db9591a
Compare
d6caa5c to
e62cc24
Compare
bc6f21d to
0a78bb9
Compare
Base automatically changed from
refactor/move-verification/vertex-methods
to
master
October 25, 2023 17:10
d2f2993 to
22c4e78
Compare
jansegre
approved these changes
Nov 3, 2023
msbrogli
approved these changes
Nov 3, 2023
22c4e78 to
2bcbc81
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #800
Motivation
This PR changes the DAA module so it stops depending on global settings, allowing its simulator patch to be removed.
Acceptance Criteria
daa.MIN_BLOCK_WEIGHTanddaa.AVG_TIME_BETWEEN_BLOCKSglobal variables, moving them to the class instance.HathorManager.VertexVerifiers.BuilderandCliBuilderaccordingly.Simulatorto use injected DAA class, removing the DAA simulator patch.daamodule to use the DAA class.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged