Conversation
1 task
This was referenced Sep 29, 2023
jansegre
previously approved these changes
Oct 3, 2023
9f2245e to
422ec12
Compare
bfc8907 to
9145c97
Compare
422ec12 to
48feebd
Compare
9145c97 to
7093fa5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #800 +/- ##
==========================================
- Coverage 84.60% 84.57% -0.03%
==========================================
Files 269 270 +1
Lines 22278 22289 +11
Branches 3402 3405 +3
==========================================
+ Hits 18848 18852 +4
- Misses 2761 2766 +5
- Partials 669 671 +2
☔ View full report in Codecov by Sentry. |
48feebd to
2bc5ebd
Compare
ca40831 to
db9591a
Compare
2bc5ebd to
4af2cfb
Compare
db9591a to
d6caa5c
Compare
4af2cfb to
7407fc6
Compare
d6caa5c to
e62cc24
Compare
7407fc6 to
c5ae653
Compare
e62cc24 to
07ff57b
Compare
msbrogli
previously approved these changes
Oct 24, 2023
c5ae653 to
78890ea
Compare
07ff57b to
363be05
Compare
78890ea to
389903c
Compare
msbrogli
reviewed
Oct 25, 2023
msbrogli
reviewed
Oct 25, 2023
432abb0 to
2ca6cb6
Compare
bc5f263 to
dc17bcb
Compare
Base automatically changed from
refactor/move-verification/transaction-methods
to
master
October 25, 2023 15:06
The base branch was changed.
dc17bcb to
f5f7fe7
Compare
msbrogli
approved these changes
Oct 25, 2023
jansegre
approved these changes
Oct 25, 2023
f5f7fe7 to
bc6f21d
Compare
bc6f21d to
0a78bb9
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #799
Motivation
This is the last PR in a 5-part series of PRs that completely move verification-related code out of the vertex model classes.
This PR moves the verification method implementations of
BaseTransaction, finishing the code migration. This also allows us to remove theverify_pow()simulator patch, as it can now be customized via injected verifiers.Acceptance Criteria
BaseTransactionverification methods from the original model classes, moving the implementation to theVertexVerifierclass.verify_outputs()implementation.Simulatorverifiers such thatverify_pow()is overridden.Simulatorto use the custom verifiers, removing theverify_pow()patch.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged