refactor(settings): change daa to use injected settings#788
Closed
glevco wants to merge 3 commits intorefactor/move-verification-methodsfrom
Closed
refactor(settings): change daa to use injected settings#788glevco wants to merge 3 commits intorefactor/move-verification-methodsfrom
glevco wants to merge 3 commits intorefactor/move-verification-methodsfrom
Conversation
glevco
force-pushed
the
refactor/daa-settings
branch
2 times, most recently
from
8aba687 to
ab9219e
Compare
1 task
glevco
force-pushed
the
refactor/move-verification-methods
branch
from
d8e40db to
c36589e
Compare
glevco
force-pushed
the
refactor/daa-settings
branch
from
ab9219e to
ba12e49
Compare
glevco
force-pushed
the
refactor/move-verification-methods
branch
3 times, most recently
from
a5b0b94 to
da50f53
Compare
Contributor
Author
|
Moved to #801 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #786
Motivation
What was the motivation for the changes in this PR?
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged