Skip to content

chore: add RocksDB and EventManager builder configs#568

Merged
glevco merged 6 commits intomasterfrom
chore/builder-methods
Apr 28, 2023
Merged

chore: add RocksDB and EventManager builder configs#568
glevco merged 6 commits intomasterfrom
chore/builder-methods

Conversation

@glevco
Copy link
Copy Markdown
Contributor

@glevco glevco commented Apr 25, 2023

Acceptance Criteria:

  • Make HathorManager receive a required EventStorage
  • Builder changes
    • Add peer_id to builder artifacts
    • Make memory be the default storage type
    • Add RockDB's cache_capacity and with_index configs
    • Add enable_event_manager() auxiliary method
  • Update usages of Builder, (CliBuilder and Simulator) to use event related configs

@glevco glevco self-assigned this Apr 25, 2023
@glevco glevco marked this pull request as ready for review April 25, 2023 19:11
jansegre
jansegre previously approved these changes Apr 25, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 25, 2023

Codecov Report

Merging #568 (3ee9570) into master (3f4238f) will increase coverage by 0.02%.
The diff coverage is 89.28%.

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
+ Coverage   83.45%   83.47%   +0.02%     
==========================================
  Files         221      221              
  Lines       19101    19140      +39     
  Branches     2618     2622       +4     
==========================================
+ Hits        15940    15977      +37     
- Misses       2584     2587       +3     
+ Partials      577      576       -1     
Impacted Files Coverage Δ
hathor/simulator/simulator.py 91.94% <60.00%> (-1.21%) ⬇️
hathor/builder/builder.py 91.06% <91.11%> (-2.25%) ⬇️
hathor/builder/cli_builder.py 78.96% <100.00%> (-0.31%) ⬇️
hathor/manager.py 70.97% <100.00%> (+0.12%) ⬆️

... and 4 files with indirect coverage changes

jansegre
jansegre previously approved these changes Apr 27, 2023
@glevco glevco force-pushed the chore/builder-methods branch from aae98a1 to 33a1b40 Compare April 27, 2023 21:29
@glevco
Copy link
Copy Markdown
Contributor Author

glevco commented Apr 27, 2023

I have moved some changes from #555 to here in f1d9c96, as they resolve most of @msbrogli's review discussions. I have updated the Acceptance Criteria accordingly

@glevco glevco force-pushed the chore/builder-methods branch from c10b442 to 3ee9570 Compare April 28, 2023 18:36
@glevco glevco merged commit 050782c into master Apr 28, 2023
@glevco glevco deleted the chore/builder-methods branch April 28, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants