chore: add RocksDB and EventManager builder configs#568
Merged
Conversation
jansegre
previously approved these changes
Apr 25, 2023
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 83.45% 83.47% +0.02%
==========================================
Files 221 221
Lines 19101 19140 +39
Branches 2618 2622 +4
==========================================
+ Hits 15940 15977 +37
- Misses 2584 2587 +3
+ Partials 577 576 -1
|
0162353 to
99ebecf
Compare
jansegre
previously approved these changes
Apr 27, 2023
99ebecf to
83b99ee
Compare
83b99ee to
aae98a1
Compare
msbrogli
requested changes
Apr 27, 2023
aae98a1 to
33a1b40
Compare
Contributor
Author
msbrogli
requested changes
Apr 27, 2023
c10b442 to
3ee9570
Compare
msbrogli
approved these changes
Apr 28, 2023
jansegre
approved these changes
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria:
HathorManagerreceive a requiredEventStorageBuilderchangespeer_idto builder artifactscache_capacityandwith_indexconfigsenable_event_manager()auxiliary methodBuilder, (CliBuilderandSimulator) to use event related configs