feat(events): remove NETWORK_BEST_BLOCK_FOUND and NETWORK_ORPHAN_BLOCK_FOUND events#537
Merged
feat(events): remove NETWORK_BEST_BLOCK_FOUND and NETWORK_ORPHAN_BLOCK_FOUND events#537
Conversation
glevco
changed the title
msbrogli
approved these changes
Mar 9, 2023
jansegre
approved these changes
Mar 9, 2023
…HAN_BLOCK_FOUND events
glevco
force-pushed
the
feat/block-events
branch
from
08077f5 to
d23afad
Compare
Codecov Report
@@ Coverage Diff @@
## dev #537 +/- ##
=======================================
Coverage 83.20% 83.21%
=======================================
Files 211 211
Lines 18646 18644 -2
Branches 2590 2590
=======================================
Hits 15514 15514
+ Misses 2563 2562 -1
+ Partials 569 568 -1
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria:
NETWORK_BEST_BLOCK_FOUNDeventNETWORK_ORPHAN_BLOCK_FOUNDeventJust like in #529, where
NETWORK_NEW_TX_VOIDEDwas removed, after discussing with @jansegre we came to the conclusion that these two events are not necessary and can be removed as well. Their functionality is already covered by existing events. It may be necessary, though, to add new attributes in the event body to represent the different types. This will be clearer when implementing an use case, and then a new PR may be created.