feat(events): remove NETWORK_NEW_TX_VOIDED event#529
Merged
Conversation
glevco
force-pushed
the
feat/voided-event
branch
from
fe9a042 to
5b70281
Compare
glevco
changed the title
glevco
changed the title
msbrogli
approved these changes
Feb 16, 2023
jansegre
approved these changes
Feb 16, 2023
glevco
force-pushed
the
feat/voided-event
branch
from
8060b6e to
69a2d54
Compare
glevco
force-pushed
the
feat/voided-event
branch
from
69a2d54 to
840f269
Compare
Codecov Report
@@ Coverage Diff @@
## dev #529 +/- ##
==========================================
- Coverage 82.91% 82.89% -0.02%
==========================================
Files 201 201
Lines 18205 18204 -1
Branches 2563 2563
==========================================
- Hits 15094 15090 -4
- Misses 2549 2550 +1
- Partials 562 564 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
glevco
added a commit
that referenced
this pull request
Feb 17, 2023
* feat(events): remove voided event * feat(events): remove voided event comment
glevco
added a commit
that referenced
this pull request
Feb 17, 2023
* feat(events): add websocket endpoint to stream events * feat(events): add TODO and other minor changes * feat(events): add EventWebsocketFactory to EventManager * feat(events): refactor EventManager * feat(events): fix EventManager instantiation on HathorManager * feat(events): start protocol and factory refactor (wip) * feat(events): create request and response classes * feat(events): finish protocol and factory refactor * feat(events): Update EventStorage interface * feat(events): update event WebSocket architecture * feat(pydantic-install): install pydantic * feat(pydantic-install): add missing docstrings * feat(events): change request to use pydantic and update response schema * feat(events): revert EventStorage changes * feat(events): remove unused settings * feat(events): update factory and protocol logic * feat(events): convert dataclasses to pydantic * feat(events): lint code * feat(events): update builder and manager * feat(events): change test utils so filepath is not hardcoded * feat(events): change builder to accept custom settings * feat(events): fix typing circular problem * feat(events): implement --x-enable-event-queue tests * feat(events): fix builder typing * feat(events): fix builder typing * feat(events): update EventStorage tests * feat(events): change protocol name * feat(events): implement factory and protocol tests * feat(events): remove incorrect assert * feat(events): update test_event_manager * feat(events): update test_event_reorg * feat(events): fix builder condition * feat(events): implement request validation and tests * feat(events): lint code * feat(events): resolve TODOs and improve tests * feat(events): add docstrings * feat(events): change test utils so filepath is not hardcoded * feat(events): change builder to accept custom settings * feat(events): fix builder typing * feat(events): fix builder typing * feat(pydantic-install): fix mypy plugin * feat(events): add event ws start/stop on manager * feat(events): fix bug and add missing test * feat(events): fix object bleeding * feat(events): improve logs * feat(events): fix lint issues * feat(events): remove unused event * feat(test-improvements): rollback builder changes * feat(test-improvements): move filepath code into function * feat(events): fix builder tests * feat(events): change HathorManager to receive EventManager * feat(events): improve logging * feat(events): change window_size_increment to window_size * feat(events): change window_size_increment to window_size * feat(events): change event factory to use callLater * feat(events): change event factory to use callLater * feat(events): lint code * feat(events): fix global pubsub on tests * feat(events): update request and response models * feat(events): update factory and protocol according to code review * feat(events): implement stream (in)active responses * feat(events): refactor code from factory to protocol * feat(events): refactor responses * feat(events): fix ack validation * feat(events): lint code * feat(events): update factory tests * feat(events): update protocol tests * feat(events): remove Python 3.10 specific code * feat(events): lint code * feat(events): fix typing * feat(events): add more python retrocompatibility changes * feat(events): implement sendMessage exception handling * feat(events): implement BaseEvent tests * feat(events): remove __future__ * refactor(indexes): Create a generic TxGroupIndex and uses it on AddressIndex * feat(events): remove NETWORK_NEW_TX_VOIDED event (#529) * feat(events): remove voided event * feat(events): remove voided event comment --------- Co-authored-by: Jan Segre <jan@hathor.network> Co-authored-by: Marcelo Salhab Brogliato <msbrogli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discussing with @jansegre , we came to the conclusion that this event is not necessary and its meaning will be covered be the
TX_METADATA_CHANGED/BLOCK_METADATA_CHANGEDevents.