Skip to content

feat(events): remove NETWORK_BEST_BLOCK_FOUND and NETWORK_ORPHAN_BLOCK_FOUND events #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glevco merged 1 commit into from
Mar 10, 2023
Merged

feat(events): remove NETWORK_BEST_BLOCK_FOUND and NETWORK_ORPHAN_BLOCK_FOUND events #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions hathor/event/event_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@

_SUBSCRIBE_EVENTS = [
HathorEvents.NETWORK_NEW_TX_ACCEPTED,
HathorEvents.NETWORK_BEST_BLOCK_FOUND,
HathorEvents.NETWORK_ORPHAN_BLOCK_FOUND,
HathorEvents.LOAD_STARTED,
HathorEvents.LOAD_FINISHED,
HathorEvents.REORG_STARTED,
Expand Down
2 changes: 0 additions & 2 deletions hathor/event/model/base_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
HathorEvents.LOAD_STARTED: EmptyData,
HathorEvents.LOAD_FINISHED: EmptyData,
HathorEvents.NETWORK_NEW_TX_ACCEPTED: TxData,
HathorEvents.NETWORK_BEST_BLOCK_FOUND: TxData,
HathorEvents.NETWORK_ORPHAN_BLOCK_FOUND: TxData,
HathorEvents.REORG_STARTED: ReorgData,
HathorEvents.REORG_FINISHED: EmptyData,
HathorEvents.VERTEX_METADATA_CHANGED: TxData,
Expand Down
12 changes: 0 additions & 12 deletions hathor/pubsub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,6 @@ class HathorEvents(Enum):
Triggered when a peer connection to the network fails
Publishes the peer id and the peers count

NETWORK_BEST_BLOCK_FOUND
Triggered when a new block is accepted in the network
Publishes a block object

NETWORK_ORPHAN_BLOCK_FOUND
Triggered when a new block is voided in the network
Publishes a block object

NETWORK_PEER_CONNECTED:
Triggered when a new peer connects to the network
Publishes the peer protocol and the peers count
Expand Down Expand Up @@ -122,10 +114,6 @@ class HathorEvents(Enum):

CONSENSUS_TX_REMOVED = 'consensus:tx_removed'

NETWORK_BEST_BLOCK_FOUND = 'network:best_block_found'

NETWORK_ORPHAN_BLOCK_FOUND = 'network:orphan_block_found'

WALLET_OUTPUT_RECEIVED = 'wallet:output_received'

WALLET_INPUT_SPENT = 'wallet:output_spent'
Expand Down
2 changes: 1 addition & 1 deletion tests/event/test_event_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def setUp(self):

def test_if_event_is_persisted(self):
block = self.manager.tx_storage.get_best_block()
self.manager.pubsub.publish(HathorEvents.NETWORK_BEST_BLOCK_FOUND, tx=block)
self.manager.pubsub.publish(HathorEvents.NETWORK_NEW_TX_ACCEPTED, tx=block)
self.run_to_completion()
self.assertIsNotNone(self.event_storage.get_event(0))

Expand Down