Conversation
1 task
jansegre
previously approved these changes
Oct 7, 2025
|
Bencher Report| Branch | fix/tx-parents |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.95 m(+12.79%)Baseline: 1.72 m | 1.55 m (79.80%) | 2.07 m (93.99%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1448 +/- ##
=======================================
Coverage 85.94% 85.95%
=======================================
Files 434 434
Lines 33675 33695 +20
Branches 5278 5285 +7
=======================================
+ Hits 28943 28962 +19
- Misses 3686 3688 +2
+ Partials 1046 1045 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
msbrogli
requested changes
Oct 9, 2025
glevco
force-pushed
the
fix/tx-parents
branch
2 times, most recently
from
7c28e4a to
d49e65c
Compare
msbrogli
previously approved these changes
Oct 9, 2025
msbrogli
previously approved these changes
Oct 9, 2025
jansegre
previously approved these changes
Oct 9, 2025
github-project-automation
bot
moved this from In Review (Done)
to In Review (WIP)
in Hathor Network
glevco
force-pushed
the
fix/tx-parents
branch
2 times, most recently
from
221773c to
3c05762
Compare
msbrogli
approved these changes
Oct 9, 2025
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix an issue where
generate_parent_txscould generate tx parents without including unconfirmed txs inmust_include.Acceptance Criteria
generate_parent_txsso it takes unconfirmed txs into account.ParentTxs: improve typing, simplify construction, and removeget_all_tips()method (it was only used in a single test).TransactionStorage.get_tx().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged