Closed
Conversation
github-project-automation
bot
moved this from Todo
to Waiting to be deployed
in Hathor Network
Contributor
Author
|
Moved to #1448 |
|
Bencher Report| Branch | refactor/tx-parents-2 |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.97 m(+14.62%)Baseline: 1.72 m | 1.55 m (78.52%) | 2.06 m (95.52%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1447 +/- ##
==========================================
- Coverage 85.96% 85.89% -0.08%
==========================================
Files 434 434
Lines 33673 33693 +20
Branches 5280 5287 +7
==========================================
- Hits 28948 28939 -9
- Misses 3684 3704 +20
- Partials 1041 1050 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
What was the motivation for the changes in this PR?
Acceptance Criteria
generate_parent_txsso it takes unconfirmed txs into account.ParentTxs:get_all_tips()method, it was only used in a single test.TransactionStorage.get_transaction_strict().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged