tests: add new tx parents tests and fix flakies#1455
Merged
Conversation
|
Bencher Report| Branch | tests/tx-parents |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.96 m(+13.68%)Baseline: 1.73 m | 1.55 m (79.17%) | 2.07 m (94.73%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1455 +/- ##
==========================================
+ Coverage 85.97% 85.99% +0.02%
==========================================
Files 434 434
Lines 33829 33829
Branches 5315 5315
==========================================
+ Hits 29083 29092 +9
+ Misses 3697 3690 -7
+ Partials 1049 1047 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
approved these changes
Oct 10, 2025
msbrogli
approved these changes
Oct 10, 2025
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
github-project-automation
bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #1448 was recently merged and caused a lot of flakiness in two tests in
test_blockchain.py, because the asserted parents and the new algorithm has a slightly different behavior.I removed those flaky asserts, and in order to make sure everything is correct, I added more tests covering all possible cases of
generate_parent_txs.Acceptance Criteria
parentsasserts fromtest_blockchain.pyto fix flakiness.generate_parent_txstestes covering all possible return cases.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged