Merged
Conversation
a4c1e68 to
008c46d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1414 +/- ##
==========================================
+ Coverage 85.90% 85.91% +0.01%
==========================================
Files 434 434
Lines 33615 33673 +58
Branches 5270 5280 +10
==========================================
+ Hits 28877 28931 +54
- Misses 3692 3697 +5
+ Partials 1046 1045 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
008c46d to
76694c9
Compare
eeddb0f to
a8a1f30
Compare
76694c9 to
d0ad86d
Compare
a8a1f30 to
bbde9c6
Compare
02df9b2 to
a04c0a1
Compare
bbde9c6 to
07654f8
Compare
a3fdf68 to
58868a9
Compare
4c51478 to
8d62cf4
Compare
71bebcd to
e28570f
Compare
5785f29 to
2dbc6e2
Compare
8c0e42e to
2a94214
Compare
c6c5312 to
d07267e
Compare
2a94214 to
366b08c
Compare
d07267e to
fa6ca38
Compare
The base branch was changed.
6e7ad3b to
7b0a57e
Compare
|
| Branch | feat/fee-header-dag-builder |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.98 m(+15.18%)Baseline: 1.72 m | 1.55 m (78.14%) | 2.06 m (95.98%) |
msbrogli
previously approved these changes
Oct 3, 2025
7b0a57e to
28ea69a
Compare
msbrogli
approved these changes
Oct 3, 2025
jansegre
approved these changes
Oct 3, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1412
Motivation
Add support for
FeeHeaderon txs via feature activation.Acceptance Criteria
FeeHeaderas an allowed header on transactions.get_maximum_number_of_headersfrom 1 to 2.ENABLE_FEE_TOKENsetting. It's replaced byENABLE_NANO_CONTRACTS, since these features will be activated together.TokenVersion.FEEand theFeeHeaderare now gated behind the nano feature activation.DAGBuilderto support:FeeHeader.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged