feat(dynamic-transaction-model): fee verification using fee header and nc#1415
Merged
feat(dynamic-transaction-model): fee verification using fee header and nc#1415
Conversation
2 tasks
9bbd517 to
792c71f
Compare
|
| Branch | raul-oliveira/fee-token-verification |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.95 m(+12.31%)Baseline: 1.73 m | 1.56 m (80.14%) | 2.08 m (93.59%) |
792c71f to
57bc472
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1415 +/- ##
==========================================
- Coverage 86.11% 86.10% -0.01%
==========================================
Files 435 436 +1
Lines 33940 34024 +84
Branches 5302 5319 +17
==========================================
+ Hits 29227 29298 +71
- Misses 3675 3681 +6
- Partials 1038 1045 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5f75b8f to
62aef14
Compare
4c51478 to
8d62cf4
Compare
d07267e to
fa6ca38
Compare
7f0a436 to
dd284fc
Compare
glevco
reviewed
Oct 2, 2025
glevco
reviewed
Oct 2, 2025
fbb6da8 to
35916b0
Compare
628d92d to
79a7653
Compare
msbrogli
requested changes
Oct 9, 2025
3bed28d to
4b5a0f5
Compare
msbrogli
requested changes
Oct 10, 2025
449847a to
75d0278
Compare
jansegre
previously approved these changes
Oct 13, 2025
75d0278 to
ecacbad
Compare
ecacbad to
c92032e
Compare
msbrogli
approved these changes
Oct 15, 2025
fbc7ceb to
72e231a
Compare
jansegre
approved these changes
Oct 15, 2025
Co-authored-by: raul-oliveira <mrraul65@gmail.com>
72e231a to
dca477b
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on 1414
Motivation
To make fee payment explicit in the transaction this pr adds the
FeeHeaderin the transaction. It carries all the tokens and amounts, indicating they will be used to pay fees.Acceptance Criteria
FeeHeaderto manipulate thetoken_dictto make fees act as outputs in the diff.verify_sumwill have a flag to indicate if it should enforce the HTR amount validation or not. This flag is useful when dealing with nano contracts that might have tokens that aren't created at the verification stage.verify_sumcall when the nano contract executes in the block_consensusfee_headerverification without storage whithin thebasicverificationon_old_new_vertexVerificationParamsto receive a block or block storageChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged