feat(dynamic-transaction-model): fee header#1412
Merged
Conversation
1af724e to
f416157
Compare
|
| Branch | raul-oliveira/fee-header |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 2.00 m(+16.35%)Baseline: 1.72 m | 1.54 m (77.35%) | 2.06 m (96.96%) |
glevco
requested changes
Sep 15, 2025
f416157 to
b6cd4b9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1412 +/- ##
==========================================
+ Coverage 85.82% 85.85% +0.03%
==========================================
Files 432 434 +2
Lines 33478 33594 +116
Branches 5247 5268 +21
==========================================
+ Hits 28731 28843 +112
- Misses 3696 3704 +8
+ Partials 1051 1047 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b6cd4b9 to
da46962
Compare
glevco
requested changes
Sep 16, 2025
glevco
reviewed
Sep 16, 2025
56abc05 to
6b00a73
Compare
glevco
reviewed
Sep 16, 2025
glevco
approved these changes
Sep 16, 2025
1 task
2 tasks
msbrogli
requested changes
Sep 17, 2025
msbrogli
reviewed
Sep 17, 2025
msbrogli
reviewed
Sep 17, 2025
a3fdf68 to
58868a9
Compare
jansegre
previously approved these changes
Oct 1, 2025
glevco
previously approved these changes
Oct 1, 2025
71bebcd to
e28570f
Compare
msbrogli
previously approved these changes
Oct 2, 2025
7769d16 to
7a2a4eb
Compare
The base branch was changed.
8c0e42e to
2a94214
Compare
glevco
previously approved these changes
Oct 2, 2025
2a94214 to
366b08c
Compare
glevco
approved these changes
Oct 2, 2025
jansegre
approved these changes
Oct 2, 2025
msbrogli
approved these changes
Oct 2, 2025
2 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on 1350
Motivation
Create a fee header to be used in the future implementation of the
verify_sumand to validate transaction fees after a nano contract execution.Acceptance Criteria
FeeEntryChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged