Skip to content

feat(dynamic-transaction-model): fee header#1412

Merged
jansegre merged 1 commit intomasterfrom
raul-oliveira/fee-header
Oct 2, 2025
Merged

feat(dynamic-transaction-model): fee header#1412
jansegre merged 1 commit intomasterfrom
raul-oliveira/fee-header

Conversation

@raul-oliveira
Copy link
Contributor

@raul-oliveira raul-oliveira commented Sep 15, 2025

Depends on 1350

Motivation

Create a fee header to be used in the future implementation of the verify_sum and to validate transaction fees after a nano contract execution.

Acceptance Criteria

  • Fee header with an array of FeeEntry
  • fee header round trip test

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@raul-oliveira raul-oliveira force-pushed the raul-oliveira/fee-header branch from 1af724e to f416157 Compare September 15, 2025 15:31
@raul-oliveira raul-oliveira self-assigned this Sep 15, 2025
@raul-oliveira raul-oliveira changed the title feat: fee header feat(dyanmic-transaction-model): fee header Sep 15, 2025
@raul-oliveira raul-oliveira changed the title feat(dyanmic-transaction-model): fee header feat(dynamic-transaction-model): fee header Sep 15, 2025
@github-actions
Copy link

github-actions bot commented Sep 15, 2025

🐰 Bencher Report

Branchraul-oliveira/fee-header
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
2.00 m
(+16.35%)Baseline: 1.72 m
1.54 m
(77.35%)
2.06 m
(96.96%)
🐰 View full continuous benchmarking report in Bencher

@raul-oliveira raul-oliveira moved this from Todo to In Progress (Done) in Hathor Network Sep 15, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Sep 15, 2025
@raul-oliveira raul-oliveira force-pushed the raul-oliveira/fee-header branch from f416157 to b6cd4b9 Compare September 16, 2025 02:48
@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 89.16667% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.85%. Comparing base (05dc565) to head (366b08c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
hathor/transaction/transaction.py 56.25% 6 Missing and 1 partial ⚠️
hathor/transaction/headers/fee_header.py 91.54% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
+ Coverage   85.82%   85.85%   +0.03%     
==========================================
  Files         432      434       +2     
  Lines       33478    33594     +116     
  Branches     5247     5268      +21     
==========================================
+ Hits        28731    28843     +112     
- Misses       3696     3704       +8     
+ Partials     1051     1047       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raul-oliveira raul-oliveira force-pushed the raul-oliveira/fee-header branch from b6cd4b9 to da46962 Compare September 16, 2025 15:07
@raul-oliveira raul-oliveira force-pushed the raul-oliveira/fee-header branch 3 times, most recently from 56abc05 to 6b00a73 Compare September 16, 2025 17:32
@glevco glevco mentioned this pull request Sep 16, 2025
1 task
@jansegre jansegre mentioned this pull request Sep 17, 2025
2 tasks
@raul-oliveira raul-oliveira force-pushed the raul-oliveira/fee-header branch from a3fdf68 to 58868a9 Compare October 1, 2025 21:25
jansegre
jansegre previously approved these changes Oct 1, 2025
glevco
glevco previously approved these changes Oct 1, 2025
@raul-oliveira raul-oliveira force-pushed the raul-oliveira/fee-header branch from 71bebcd to e28570f Compare October 1, 2025 22:03
msbrogli
msbrogli previously approved these changes Oct 2, 2025
@raul-oliveira raul-oliveira force-pushed the raul-oliveira/create-fee-tokens-in-nano branch 4 times, most recently from 7769d16 to 7a2a4eb Compare October 2, 2025 19:39
@raul-oliveira raul-oliveira changed the base branch from raul-oliveira/create-fee-tokens-in-nano to master October 2, 2025 19:40
@raul-oliveira raul-oliveira dismissed stale reviews from msbrogli, glevco, and jansegre October 2, 2025 19:40

The base branch was changed.

@glevco glevco force-pushed the raul-oliveira/fee-header branch 2 times, most recently from 8c0e42e to 2a94214 Compare October 2, 2025 20:48
glevco
glevco previously approved these changes Oct 2, 2025
@glevco glevco force-pushed the raul-oliveira/fee-header branch from 2a94214 to 366b08c Compare October 2, 2025 20:51
@raul-oliveira raul-oliveira enabled auto-merge (squash) October 2, 2025 22:08
@jansegre jansegre merged commit 1a83ecb into master Oct 2, 2025
13 of 14 checks passed
@jansegre jansegre deleted the raul-oliveira/fee-header branch October 2, 2025 22:27
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Oct 2, 2025
@jansegre jansegre mentioned this pull request Oct 7, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Oct 15, 2025
@jansegre jansegre mentioned this pull request Oct 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants