Skip to content

chore(nano): migration to prevent use of incompatible storage#1380

Merged
jansegre merged 1 commit intomasterfrom
chore/nano-storage-compat-migration
Sep 10, 2025
Merged

chore(nano): migration to prevent use of incompatible storage#1380
jansegre merged 1 commit intomasterfrom
chore/nano-storage-compat-migration

Conversation

@jansegre
Copy link
Member

Motivation

Some recent changes to the nanocontracts storage make it incompatible with an existing storage (like #1378 and #1312).

Acceptance Criteria

  • Add an "impossible" migration to prevent use of an incompatible storage and force using a recent snapshot or a sync from scratch

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested review from glevco and msbrogli August 22, 2025 17:51
@jansegre jansegre self-assigned this Aug 22, 2025
@jansegre jansegre moved this from Todo to In Progress (Done) in Hathor Network Aug 22, 2025
@glevco glevco moved this from In Progress (Done) to In Review (WIP) in Hathor Network Aug 22, 2025
@github-actions
Copy link

github-actions bot commented Aug 22, 2025

🐰 Bencher Report

Branchchore/nano-storage-compat-migration
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.84 m
(+9.10%)Baseline: 1.68 m
1.52 m
(82.49%)
2.02 m
(90.91%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.84%. Comparing base (eb235f2) to head (9bf9151).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ansaction/storage/migrations/nc_storage_compat1.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
- Coverage   85.86%   85.84%   -0.02%     
==========================================
  Files         431      432       +1     
  Lines       32733    32744      +11     
  Branches     5102     5102              
==========================================
+ Hits        28105    28109       +4     
- Misses       3608     3610       +2     
- Partials     1020     1025       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre moved this from In Review (WIP) to In Review (Done) in Hathor Network Sep 10, 2025
@jansegre jansegre force-pushed the chore/nano-storage-compat-migration branch from 26e0e9e to 9bf9151 Compare September 10, 2025 18:33
@jansegre jansegre merged commit 6ebe92e into master Sep 10, 2025
8 checks passed
@jansegre jansegre deleted the chore/nano-storage-compat-migration branch September 10, 2025 19:34
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Sep 10, 2025
@jansegre jansegre mentioned this pull request Sep 11, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants