Skip to content

chore(nano): avoid storage incompatibility when nano is not enabled#1428

Merged
jansegre merged 1 commit intohotfixesfrom
chore/avoid-unnecessary-migration
Sep 25, 2025
Merged

chore(nano): avoid storage incompatibility when nano is not enabled#1428
jansegre merged 1 commit intohotfixesfrom
chore/avoid-unnecessary-migration

Conversation

@jansegre
Copy link
Member

Motivation

The "impossible migration" introduced in #1380 was having an effect on mainnet even though it only affects the nano storage which doesn't exist yet in mainnet.

Acceptance Criteria

  • Only include migration if settings.ENABLE_NANO_CONTRACTS

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Sep 25, 2025
@jansegre jansegre requested a review from msbrogli as a code owner September 25, 2025 16:45
@jansegre jansegre moved this from Todo to In Progress (Done) in Hathor Network Sep 25, 2025
@github-project-automation github-project-automation bot moved this from In Progress (Done) to In Review (WIP) in Hathor Network Sep 25, 2025
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.74%. Comparing base (156239b) to head (41d1ec9).
⚠️ Report is 2 commits behind head on hotfixes.

Additional details and impacted files
@@             Coverage Diff              @@
##           hotfixes    #1428      +/-   ##
============================================
- Coverage     85.84%   85.74%   -0.11%     
============================================
  Files           430      430              
  Lines         33061    33064       +3     
  Branches       5171     5172       +1     
============================================
- Hits          28381    28350      -31     
- Misses         3648     3672      +24     
- Partials       1032     1042      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre merged commit 52edd58 into hotfixes Sep 25, 2025
6 of 7 checks passed
@jansegre jansegre deleted the chore/avoid-unnecessary-migration branch September 25, 2025 17:18
@github-project-automation github-project-automation bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network Sep 25, 2025
This was referenced Sep 25, 2025
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants