Skip to content

feat(nano): change internal storage hashing to sha256#1378

Merged
jansegre merged 1 commit intomasterfrom
feat/nano-sha256-storage
Aug 22, 2025
Merged

feat(nano): change internal storage hashing to sha256#1378
jansegre merged 1 commit intomasterfrom
feat/nano-sha256-storage

Conversation

@jansegre
Copy link
Member

Motivation

Benchmark shows similar (and slightly better) performance in some cases.

Acceptance Criteria

  • Use SHA256 for storage hashing (both the patricia-trie and attribute-keys)

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@github-actions
Copy link

github-actions bot commented Aug 22, 2025

🐰 Bencher Report

Branchfeat/nano-sha256-storage
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.86 m
(+11.34%)Baseline: 1.67 m
1.50 m
(80.83%)
2.01 m
(92.78%)
🐰 View full continuous benchmarking report in Bencher

@jansegre jansegre moved this from Todo to In Progress (Done) in Hathor Network Aug 22, 2025
@jansegre jansegre force-pushed the feat/nano-sha256-storage branch from 85edc53 to 2f65827 Compare August 22, 2025 14:35
@jansegre jansegre moved this from In Progress (Done) to In Review (WIP) in Hathor Network Aug 22, 2025
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.63%. Comparing base (7707b6c) to head (2f65827).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1378      +/-   ##
==========================================
- Coverage   85.67%   85.63%   -0.05%     
==========================================
  Files         429      429              
  Lines       32450    32450              
  Branches     5068     5068              
==========================================
- Hits        27802    27788      -14     
- Misses       3620     3631      +11     
- Partials     1028     1031       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Aug 22, 2025
@jansegre jansegre merged commit ea93f66 into master Aug 22, 2025
8 checks passed
@jansegre jansegre deleted the feat/nano-sha256-storage branch August 22, 2025 17:48
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Aug 22, 2025
@jansegre jansegre mentioned this pull request Sep 11, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Sep 18, 2025
@jansegre jansegre mentioned this pull request Sep 24, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants