Merged
Conversation
|
| Branch | raul-oliveira/dynamic-transaction-model |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.82 m(+8.30%)Baseline: 1.68 m | 1.51 m (83.10%) | 2.02 m (90.25%) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1255 +/- ##
==========================================
- Coverage 85.91% 85.90% -0.01%
==========================================
Files 430 431 +1
Lines 32570 32688 +118
Branches 5072 5093 +21
==========================================
+ Hits 27981 28081 +100
- Misses 3575 3589 +14
- Partials 1014 1018 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
requested changes
Apr 15, 2025
glevco
requested changes
Apr 16, 2025
1 task
glevco
requested changes
Apr 17, 2025
glevco
requested changes
Apr 17, 2025
glevco
requested changes
Apr 17, 2025
msbrogli
requested changes
Apr 22, 2025
glevco
previously approved these changes
Aug 14, 2025
5fa1d7e to
9a7648b
Compare
glevco
previously approved these changes
Aug 20, 2025
5285725 to
b12c1e1
Compare
jansegre
previously approved these changes
Aug 26, 2025
glevco
previously approved these changes
Aug 26, 2025
msbrogli
previously approved these changes
Aug 28, 2025
fb9fe3a
b79ee26 to
64d840a
Compare
msbrogli
previously approved these changes
Sep 4, 2025
jansegre
approved these changes
Sep 9, 2025
msbrogli
approved these changes
Sep 9, 2025
glevco
approved these changes
Sep 9, 2025
This was referenced Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
According to the docs:
This PR adds the fee logic, either by creating a new token version (
TokenInfoVersion.FEE) to be and by the refactor ofverify_sum.It will add thefee.pyfile containingcalculate_fee()andshould_charge_fee()methods. It also change thetransaction_verifier.verify_sum()method to receive the entiretxand orchestrate the fee.Acceptance Criteria
FEEshould be created.token_info.py.TOKEN_INFO_VERSIONconstant should be updated to the newTokenInfoVersionenum.FEE_FEATURE_FLAGwith False as the default value, True only for testing.fee.pyfile with bothcalculate_feeandshould_charge_feemethods.get_token_creation_transactionmethod in thetransaction_storage.py.token_info_versionparameter to thetoken_creation_tx.pyconstructor.__str__method to write thetoken_info_version.serialize_token_infoto accept the created parameter.deserialize_token_infomethod to accept only the values in theTokenInfoVersion.versionfield toTokenInfoto be used in the dicts.get_token_info_from_inputsfetch thetoken_info_versionfrom the token creation tx.get_spent_outputs,get_spent_outputs_grouped_by_token_uid, andget_outputs_grouped_by_token_uidmethods in thetransaction class.get_withdraw_amountandget_deposit_amountfromtransaction/utilstoget_deposit_token_witndraw_amountandget_deposit_token_withdraw_amount.get_deposit_token_amount_from_htrintest/utils.token_creation_tx_verifier.verify_token_infoto check if the fee feature is enabled before accepting the newtoken_info_version.verify_sumto match the reference level implementation in the rfc.not implementedexception.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged