Skip to content

refact(core): moves TokenInfo and TokenInfoVersion to a test_tokens.py#1260

Merged
raul-oliveira merged 4 commits intoraul-oliveira/dynamic-transaction-modelfrom
raul-oliveira/token-info-refactor
Apr 23, 2025
Merged

refact(core): moves TokenInfo and TokenInfoVersion to a test_tokens.py#1260
raul-oliveira merged 4 commits intoraul-oliveira/dynamic-transaction-modelfrom
raul-oliveira/token-info-refactor

Conversation

@raul-oliveira
Copy link
Contributor

Motivation

Address the refactor comment made by @glevco

Acceptance Criteria

  • TokenInfo and TokenInfoVersion must be outside the Transaction class

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@github-actions
Copy link

🐰 Bencher Report

Branchraul-oliveira/token-info-refactor
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.65 m
(+1.19%)Baseline: 1.63 m
1.47 m
(88.95%)
1.80 m
(91.99%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 95.68966% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.16%. Comparing base (3884dc3) to head (b42a07b).

Files with missing lines Patch % Lines
hathor/transaction/token_creation_tx.py 78.57% 2 Missing and 1 partial ⚠️
hathor/transaction/fee.py 95.34% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1260   +/-   ##
=======================================
  Coverage   84.15%   84.16%           
=======================================
  Files         311      313    +2     
  Lines       23869    23952   +83     
  Branches     3651     3669   +18     
=======================================
+ Hits        20088    20160   +72     
- Misses       3065     3073    +8     
- Partials      716      719    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raul-oliveira raul-oliveira changed the base branch from master to raul-oliveira/dynamic-transaction-model April 21, 2025 22:06
@raul-oliveira raul-oliveira force-pushed the raul-oliveira/token-info-refactor branch from da9315b to ac4957b Compare April 23, 2025 13:05
@raul-oliveira raul-oliveira merged commit e2225d6 into raul-oliveira/dynamic-transaction-model Apr 23, 2025
2 of 8 checks passed
@raul-oliveira raul-oliveira deleted the raul-oliveira/token-info-refactor branch April 23, 2025 13:50
@github-project-automation github-project-automation bot moved this from In Progress (Done) to Waiting to be deployed in Hathor Network Apr 23, 2025
@raul-oliveira raul-oliveira moved this from Waiting to be deployed to Done in Hathor Network May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant