Skip to content

fix(nano): temporary alias to keep compatibility with testnet-hotel#1402

Merged
jansegre merged 1 commit intomasterfrom
fix/nano/compat-alias
Sep 11, 2025
Merged

fix(nano): temporary alias to keep compatibility with testnet-hotel#1402
jansegre merged 1 commit intomasterfrom
fix/nano/compat-alias

Conversation

@jansegre
Copy link
Member

Motivation

We ended up introducing a regression with #1255 when it renamed self.syscall.create_token to self.syscall.create_deposit_token.

Acceptance Criteria

  • Create an alias so that self.syscall.create_token works. We should remove this alias before mainnet when we break compatibility with testnet-hotel.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

glevco
glevco previously approved these changes Sep 10, 2025
@github-actions
Copy link

github-actions bot commented Sep 10, 2025

🐰 Bencher Report

Branchfix/nano/compat-alias
Testbedubuntu-22.04

🚨 1 Alert

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Upper Boundary
(Limit %)
sync-v2 (up to 20000 blocks)Latency
minutes (m)
📈 plot
🚷 threshold
🚨 alert (🔔)
2.04 m
(+20.81%)Baseline: 1.69 m
2.02 m
(100.67%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
🚨 view alert (🔔)
2.04 m
(+20.81%)Baseline: 1.69 m
1.52 m
(74.50%)
2.02 m
(100.67%)

🐰 View full continuous benchmarking report in Bencher

msbrogli
msbrogli previously approved these changes Sep 10, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Review (WIP) in Hathor Network Sep 10, 2025
@jansegre jansegre dismissed stale reviews from msbrogli and glevco via ec34dfe September 10, 2025 22:55
@jansegre jansegre force-pushed the fix/nano/compat-alias branch from 5ce915d to ec34dfe Compare September 10, 2025 22:55
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.88%. Comparing base (6ebe92e) to head (ec34dfe).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
+ Coverage   85.82%   85.88%   +0.05%     
==========================================
  Files         432      432              
  Lines       32744    32745       +1     
  Branches     5102     5102              
==========================================
+ Hits        28103    28122      +19     
+ Misses       3614     3603      -11     
+ Partials     1027     1020       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansegre jansegre moved this from In Review (WIP) to In Review (Done) in Hathor Network Sep 11, 2025
@github-project-automation github-project-automation bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Sep 11, 2025
@glevco glevco moved this from In Review (WIP) to In Review (Done) in Hathor Network Sep 11, 2025
@jansegre jansegre merged commit f3e4df2 into master Sep 11, 2025
7 of 8 checks passed
@jansegre jansegre deleted the fix/nano/compat-alias branch September 11, 2025 16:19
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Sep 11, 2025
@jansegre jansegre mentioned this pull request Sep 11, 2025
2 tasks
@jansegre jansegre moved this from Waiting to be deployed to Done in Hathor Network Sep 18, 2025
@jansegre jansegre mentioned this pull request Sep 24, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants