fix(nano): temporary alias to keep compatibility with testnet-hotel#1402
Merged
fix(nano): temporary alias to keep compatibility with testnet-hotel#1402
Conversation
glevco
previously approved these changes
Sep 10, 2025
|
| Branch | fix/nano/compat-alias |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency minutes (m) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 2.04 m(+20.81%)Baseline: 1.69 m | 2.02 m (100.67%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 2.04 m(+20.81%)Baseline: 1.69 m | 1.52 m (74.50%) | 2.02 m (100.67%) |
msbrogli
previously approved these changes
Sep 10, 2025
5ce915d to
ec34dfe
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
+ Coverage 85.82% 85.88% +0.05%
==========================================
Files 432 432
Lines 32744 32745 +1
Branches 5102 5102
==========================================
+ Hits 28103 28122 +19
+ Misses 3614 3603 -11
+ Partials 1027 1020 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
approved these changes
Sep 11, 2025
glevco
approved these changes
Sep 11, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We ended up introducing a regression with #1255 when it renamed
self.syscall.create_tokentoself.syscall.create_deposit_token.Acceptance Criteria
self.syscall.create_tokenworks. We should remove this alias before mainnet when we break compatibility withtestnet-hotel.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged