Merged
Conversation
95fe33e to
b9b67c5
Compare
|
| Report | Thu, August 22, 2024 at 19:30:56 UTC |
| Project | hathor-core |
| Branch | fix/healthcheck-content-type |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | ✅ (view plot) | 104,042,467,308.64 (+1.27%) | 92,461,354,314.26 (88.87%) | 113,008,321,939.65 (92.07%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1110 +/- ##
==========================================
- Coverage 84.64% 84.63% -0.02%
==========================================
Files 317 317
Lines 24149 24150 +1
Branches 3665 3665
==========================================
- Hits 20441 20439 -2
- Misses 3002 3005 +3
Partials 706 706 ☔ View full report in Codecov by Sentry. |
b9b67c5 to
9880491
Compare
1 task
jansegre
approved these changes
Aug 20, 2024
glevco
approved these changes
Aug 20, 2024
9880491 to
8f8f97e
Compare
8f8f97e to
a0e3210
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We are getting an error from aiohttp in explorer-service when trying to get
/healthfrom hathor-core and parse it as json.Acceptance Criteria
/healthendpoint should use the correct Content-Type which should beapplication/json, instead oftext/htmlChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged