Skip to content

fix: hathor-core healthcheck#332

Merged
luislhl merged 3 commits intodevfrom
fix/hathor-core-healthcheck
Aug 23, 2024
Merged

fix: hathor-core healthcheck#332
luislhl merged 3 commits intodevfrom
fix/hathor-core-healthcheck

Conversation

@luislhl
Copy link
Copy Markdown
Contributor

@luislhl luislhl commented Aug 19, 2024

Acceptance Criteria

  • We should expect to receive a response with Content-Type text/html from hathor-core's health endpoint, and make aiohttp parse it without errors.
  • After fix: healthcheck content-type hathor-core#1110 gets released, we will be able to revert this change. I preferred to do it instead of waiting for hathor-core, because it could take too long.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@luislhl luislhl self-assigned this Aug 19, 2024
@luislhl luislhl requested a review from r4mmer as a code owner August 19, 2024 02:06
@luislhl luislhl requested a review from alexruzenhack August 20, 2024 18:34
@luislhl luislhl merged commit dbb4b20 into dev Aug 23, 2024
@luislhl luislhl deleted the fix/hathor-core-healthcheck branch August 23, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants