Skip to content

fix: healthcheck content-type #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luislhl merged 1 commit into from
Aug 22, 2024
Merged

fix: healthcheck content-type #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hathor/healthcheck/resources/healthcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def _render_success(self, result: HealthcheckResponse, request: Request) -> None
status_code = result.get_http_status_code()
request.setResponseCode(status_code)

request.setHeader(b'content-type', b'application/json; charset=utf-8')
request.write(json_dumpb(result.to_json()))
request.finish()

Expand Down
1 change: 1 addition & 0 deletions tests/resources/healthcheck/test_healthcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ def test_get_ready(self):
response = yield self.web.get('/health')
data = response.json_value()

self.assertTrue('application/json; charset=utf-8' in response.responseHeaders.getRawHeaders('content-type'))
self.assertEqual(response.responseCode, 200)
self.assertEqual(data, {
'status': 'pass',
Expand Down